Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTENT] on "My programs" page, localization does not work for Adventure names #4570

Closed
yilmazdurmaz opened this issue Sep 29, 2023 · 6 comments · Fixed by #4846
Closed
Assignees
Labels
teacher-happiness Features that make teachers happier

Comments

@yilmazdurmaz
Copy link
Contributor

When is "my programs" page, adventure names show their literal values without translations such as {if} & {else}
This happens at least for Turkish

adventure name shown on saved program
Screenshot (4)

and adventure names in the dropdown list
Screenshot (5)

Expected text
Localization process should include these parts of the page and translate them. {if} & {else} would then be eğer & değilse

@Felienne
Copy link
Member

Great find @yilmazdurmaz! We will look into this.

@yilmazdurmaz
Copy link
Contributor Author

@Felienne I think this is the right time and place to mention and old issue, #4134. I guess it has been forgotten since it has a "UI-idea" label, but I think this also need attention at the same level as this one.

@Felienne
Copy link
Member

@Felienne I think this is the right time and place to mention and old issue, #4134. I guess it has been forgotten since it has a "UI-idea" label, but I think this also need attention at the same level as this one.

Yes, it could be fixed by the same code potentially.

However, I want to ask you to communicate in the way as we ask in our Wiki. Saying that something is "forgotten" is not appropriate; almost all of us are volunteers and we work as hard as we can. Please understand that we are doing our best, and we do not have enough bandwidth to fix all issues as quick as we would all like.

If you absolutely feel something needs attention, you are very welcome to create a PR for it yourself, and we are also happy to help you get started, if the wiki does not suffice in information.

@yilmazdurmaz
Copy link
Contributor Author

Saying that something is "forgotten" is not appropriate

Forgive my words of choices. I wasn't thinking of any offending meaning here. I had this in mind: the "common mistakes" part is another important bridge between teachers and students.

@Felienne
Copy link
Member

Thank you!

The connection between the issues indeed is meaningful and helpful! Likely we can tackle both with one PR. I will look at it when I have the chance (which will be after the weekend)

@yilmazdurmaz
Copy link
Contributor Author

By the way, the common mistakes content would also be very useful to all students, especially to self-learners. Moving that section to its own page with visibility to all students may not only help all learners, but also help this keyword translation process.
Worth to consider later, but maybe before working on that page all together.
PS: I will make a duplicate of this sentence in the other issue as a reminder, for it mainly belongs there.

@Felienne Felienne pinned this issue Oct 4, 2023
@Felienne Felienne unpinned this issue Oct 4, 2023
@Felienne Felienne added the teacher-happiness Features that make teachers happier label Nov 14, 2023
@mergify mergify bot closed this as completed in #4846 Dec 7, 2023
mergify bot pushed a commit that referenced this issue Dec 7, 2023
Fixes #4570

How to test: Go to the My Programs page, click 'Adventures', the command adventures are now localized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
teacher-happiness Features that make teachers happier
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants