Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI idea] Localized keywords in the teacher manual #4134

Closed
MarleenGilsing opened this issue Mar 16, 2023 · 2 comments · Fixed by #5167
Closed

[UI idea] Localized keywords in the teacher manual #4134

MarleenGilsing opened this issue Mar 16, 2023 · 2 comments · Fixed by #5167
Assignees
@jpelay
Labels
teacher-happiness Features that make teachers happier

Comments

@MarleenGilsing
Copy link
Collaborator

The teacher manual doesn't use localized keywords, only the English ones. It would be nice if the keywords could change to the preferred language setting of the teacher. I mainly mean in the common mistakes section.

I've tried to just use the { } around the keywords, but that didn't do the trick.
@yilmazdurmaz
Copy link
Contributor

We have curlies for half of the translation for both the text and the code. But unfortunately, they do not work the way we translators expected them.

This resulted in this Frankenstein's monster
teachers manual

@yilmazdurmaz yilmazdurmaz mentioned this issue Sep 29, 2023
Closed
@yilmazdurmaz
Copy link
Contributor

yilmazdurmaz commented Sep 29, 2023 •
edited
Loading

By the way, the common mistakes content would also be very useful to all students, especially to self-learners. Moving that section to its own page with visibility to all students may not only help all learners, but also help this keyword translation process.
Worth to consider later, but maybe before working on that page all together.

PS: This is a duplicate of my sentence in the other issue I mentioned about this, for this mainly belongs here.

@Felienne Felienne added the teacher-happiness Features that make teachers happier label Nov 14, 2023
@Felienne Felienne mentioned this issue Dec 13, 2023
Closed
@Annelein Annelein removed their assignment Feb 15, 2024
@jpelay jpelay self-assigned this Feb 20, 2024
@jpelay jpelay mentioned this issue Feb 20, 2024
Merged
@mergify mergify bot closed this as completed in #5167 Aug 5, 2024
mergify bot pushed a commit that referenced this issue Aug 5, 2024
@jpelay
🪲 Translate keywords in the teacher manual (#5167)
967dbeb 
In this PR I want to tackle the translation of keywords in the teacher manual. First, we need to allow the keywords to be translated using the curly brace system we use already in the adventures, that is simple enough to do and requires only the call to a function; after that we need to test the programs inside the yamls in the teacher manual, because when they do have curly braces, sometimes they're not correctly. And third, what do we do with the mess we already have?

For example in Spanish there's a mixture of several methods:

* Sometimes the keywords are directly translated
```
bebida = preguntar '¿Qué te gustaría beber?'
imprimir bebida
bebida = preguntar '¿Qué te gustaría beber?'
imprimir bebida
bebida = preguntar '¿Qué te gustaría beber?'
imprimir bebida
```
* Sometimes they have curly braces:
```
superhéroes = Spiderman, Batman, Iron Man
superhéroe = superhéroes {at} {random}
{if} superhéroe = Batman
    {print} '¡SOY BATMAN!'
```
* Sometimes they have intentional errors.
* Sometimes they have unintentional errors

Fixes #4134

**How to test**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpelay jpelay

Labels
teacher-happiness Features that make teachers happier
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🪲 Translate keywords in the teacher manual hedyorg/hedy
5 participants
@Felienne @yilmazdurmaz @jpelay @Annelein @MarleenGilsing