Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI installation check option. #1387

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Conversation

DarioSamo
Copy link
Contributor

@DarioSamo DarioSamo commented Mar 15, 2025

Closes #1357.

TODO

  • Japanese
  • German
  • French
  • Spanish
  • Italian

Sorry, something went wrong.

@DeaTh-G
Copy link
Contributor

DeaTh-G commented Mar 18, 2025

@LJSTARbird @brianuuu @Kitzuku @NextinMono Please provide translations for the following two newly added strings. They appear on a basic message window not within the game itself.

{ ELanguage::English,  "Installation check has finished.\n\nAll files seem to be correct.\n\nThe game will now close. Remove the launch argument to play the game." }
{ ELanguage::English,  "Installation check has failed.\n\nError: %s\n\nThe game will now close. Try reinstalling the game by using the --install launch argument." }

@NextinMono
Copy link
Contributor

{ ELanguage::Italian,  "La verifica dei file d'installazione è terminata.\n\nTutti i file sembrano corretti.\n\nIl gioco si chiuderà. Rimuovi l'argomento di avvio per poter giocare." }
{ ELanguage::Italian,  "La verifica dei file d'installazione non è andata a buon fine.\n\nErrore: %s\n\nIl gioco si chiuderà. Prova a reinstallare il gioco utilizzando l'argomento di avvio --install." }

@Kitzuku
Copy link
Contributor

Kitzuku commented Mar 18, 2025

{ ELanguage::German,  "Die Installation wurde überprüft.\n\nAlle Dateien scheinen korrekt zu sein.\n\nDas Spiel wird nun geschlossen. Entferne die Startoption, um das Spiel zu spielen." }
{ ELanguage::German,  "Die Installationsprüfung ist fehlgeschlagen.\n\nFehler: %s\n\nDas Spiel wird nun geschlossen. Versuche das Spiel durch Verwendung der Startoption --install neu zu installieren." }

@brianuuu
Copy link
Contributor

{ ELanguage::Japanese, "インストールチェックが終了しました\n\nすべてのファイルは正しいようです\n\nゲームは終了します、ゲームをプレイするには起動引数を削除してください" },
{ ELanguage::Japanese, "インストールチェックに失敗しました\n\nエラー:%s\n\nゲームは終了します、--install 起動引数を使用してゲームを再インストールしてください" },

@hyperbx hyperbx added this to the v1.0.3 milestone Mar 19, 2025
@LJSTARbird
Copy link
Contributor

{ ELanguage::French,  "La vérification de l'installation est terminée.\n\nTous les fichiers semblent corrects.\n\nL'application va maintenant se fermer. Retirez l'argument de lancement pour pouvoir lancer le jeu." }

{ ELanguage::French,  "La vérification de l'installation a échoué.\n\nErreur : %s\n\nL'application va maintenant se fermer. Essayez de réinstaller le jeu en utilisant l'argument de lancement --install." }

@DarioSamo
Copy link
Contributor Author

Translations have been added.

Copy link
Member

@blueskythlikesclouds blueskythlikesclouds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A command line window doesn't get shown in release builds on Windows, acting as if the application just exited when it's actually validating in the background.

Should explicitly allocate the console with os::process:ShowConsole()

@blueskythlikesclouds blueskythlikesclouds merged commit 53596b8 into main Mar 28, 2025
9 checks passed
@blueskythlikesclouds blueskythlikesclouds deleted the integrity-check branch March 28, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Integrity Check commandline option.
8 participants