Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Bytes -> TextEncodingNone #460

Merged
merged 5 commits into from
Mar 29, 2022
Merged

Rename Bytes -> TextEncodingNone #460

merged 5 commits into from
Mar 29, 2022

Conversation

guilhermeleobas
Copy link
Contributor

@guilhermeleobas guilhermeleobas commented Mar 23, 2022 •
edited
Loading

As title.

@guilhermeleobas guilhermeleobas added the enhancement New feature or request label Mar 24, 2022
@guilhermeleobas guilhermeleobas force-pushed the guilhermeleobas/textencodingnone branch from 207cc23 to e0bdddf Compare March 24, 2022 02:19
@guilhermeleobas guilhermeleobas marked this pull request as ready for review March 24, 2022 23:45
@guilhermeleobas guilhermeleobas force-pushed the guilhermeleobas/textencodingnone branch from baa26cb to 1bc8ac0 Compare March 24, 2022 23:46
@guilhermeleobas guilhermeleobas self-assigned this Mar 24, 2022
@guilhermeleobas guilhermeleobas requested review from pearu and tupui March 25, 2022 03:14
tupui
tupui reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guilhermeleobas, I have a few suggestions.

pearu
pearu reviewed Mar 27, 2022
View reviewed changes
Copy link
Contributor

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but requires resolving merge conflicts.

Thanks, @guilhermeleobas , for this update!

tupui
tupui approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too now.

@guilhermeleobas guilhermeleobas force-pushed the guilhermeleobas/textencodingnone branch from d44127e to 05b8442 Compare March 29, 2022 14:52
@guilhermeleobas guilhermeleobas force-pushed the guilhermeleobas/textencodingnone branch from 05b8442 to 1263eab Compare March 29, 2022 14:58
pearu
pearu approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guilhermeleobas guilhermeleobas merged commit c86055b into heavyai:master Mar 29, 2022
@guilhermeleobas guilhermeleobas deleted the guilhermeleobas/textencodingnone branch March 29, 2022 16:43
@guilhermeleobas guilhermeleobas mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearu pearu pearu approved these changes

@tupui tupui tupui approved these changes

Assignees

@guilhermeleobas guilhermeleobas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermeleobas @pearu @tupui