Address reviewer comments

Author: guilhermeleobas

doc/api.rst

@@ -59,8 +59,8 @@ Externals
     externals.stdio
 
 
-OmniSciDB Backend
-=================
+HeavyDB Backend
+===============
 
 The table below contains the data structures available for the HeavyDB backend.
 It should be noticed that the following types are not regular Python types but

rbc/heavyai/array.py

@@ -6,7 +6,7 @@
 from rbc import typesystem, errors
 from .buffer import (BufferPointer, Buffer,
                      OmnisciBufferType,
-                     omnisci_buffer_constructor)
+                     heavydb_buffer_constructor)
 from numba.core import extending, types
 from typing import Union, TypeVar
 
@@ -135,7 +135,7 @@ def T(self):
 @extending.lower_builtin(Array, types.Integer, types.StringLiteral)
 @extending.lower_builtin(Array, types.Integer, types.NumberClass)
 def omnisci_array_constructor(context, builder, sig, args):
-    return omnisci_buffer_constructor(context, builder, sig, args)
+    return heavydb_buffer_constructor(context, builder, sig, args)
 
 
 @extending.type_callable(Array)

rbc/heavyai/buffer.py

@@ -160,7 +160,7 @@ class ArrayPointerModel(BufferPointerModel):
     """
 
 
-def omnisci_buffer_constructor(context, builder, sig, args):
+def heavydb_buffer_constructor(context, builder, sig, args):
     """
 
     Usage:

rbc/heavyai/text_encoding_dict.py

@@ -1,4 +1,4 @@
-'''Omnisci TextEncodingDict type that corresponds to Omnisci type TEXT ENCODED DICT.
+'''HeavyDB TextEncodingDict type that corresponds to HeavyDB type TEXT ENCODED DICT.
 '''
 
 __all__ = ['OmnisciTextEncodingDictType', 'TextEncodingDict']

rbc/heavyai/text_encoding_none.py

@@ -1,4 +1,4 @@
-'''Omnisci TextEncodingNone type that corresponds to Omnisci type TEXT ENCODED NONE.
+'''HeavyDB TextEncodingNone type that corresponds to HeavyDB type TEXT ENCODED NONE.
 '''
 
 __all__ = ['TextEncodingNonePointer', 'TextEncodingNone', 'HeavyDBTextEncodingNoneType']
@@ -9,14 +9,14 @@
 from rbc.errors import RequireLiteralValue
 from .buffer import (
     BufferPointer, Buffer, OmnisciBufferType,
-    omnisci_buffer_constructor)
+    heavydb_buffer_constructor)
 from numba.core import types, extending, cgutils
 from llvmlite import ir
 from typing import Union
 
 
 class HeavyDBTextEncodingNoneType(OmnisciBufferType):
-    """Omnisci TextEncodingNone type for RBC typesystem.
+    """HeavyDB TextEncodingNone type for RBC typesystem.
     """
 
     @property
@@ -118,20 +118,20 @@ def impl(a, b):
 
 
 @extending.lower_builtin(TextEncodingNone, types.Integer)
-def omnisci_text_encoding_none_constructor(context, builder, sig, args):
-    return omnisci_buffer_constructor(context, builder, sig, args)
+def heavydb_text_encoding_none_constructor(context, builder, sig, args):
+    return heavydb_buffer_constructor(context, builder, sig, args)
 
 
 @extending.lower_builtin(TextEncodingNone, types.StringLiteral)
-def omnisci_text_encoding_none_constructor_literal(context, builder, sig, args):
+def heavydb_text_encoding_none_constructor_literal(context, builder, sig, args):
     int64_t = ir.IntType(64)
     int8_t_ptr = ir.IntType(8).as_pointer()
 
     literal_value = sig.args[0].literal_value
     sz = int64_t(len(literal_value))
 
     # arr = {ptr, size, is_null}*
-    arr = omnisci_buffer_constructor(context, builder, sig.return_type(types.int64), [sz])
+    arr = heavydb_buffer_constructor(context, builder, sig.return_type(types.int64), [sz])
     ptr = builder.extract_value(builder.load(arr), [0])
 
     msg_bytes = literal_value.encode('utf-8')
@@ -144,7 +144,7 @@ def omnisci_text_encoding_none_constructor_literal(context, builder, sig, args):
 
 
 @extending.type_callable(TextEncodingNone)
-def type_omnisci_text_encoding_none(context):
+def type_heavydb_text_encoding_none(context):
     def typer(arg):
         if isinstance(arg, types.UnicodeType):
             raise RequireLiteralValue()

rbc/tests/heavyai/test_text_encoding.py

@@ -227,7 +227,6 @@ def test_text_encoding_column_list2(heavydb, size):
 @pytest.mark.usefixtures("create_columns")
 @pytest.mark.parametrize("size", (32,))
 @pytest.mark.parametrize("num_cols", (1, 2, 3, 4))
-@pytest.mark.skip()
 def test_text_encoding_column_list3(heavydb, size, num_cols):
     heavydb.require_version((5, 7), "Requires heavydb-internal PR 5719")