Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-668 Document and Validate Properties #1001

Merged
merged 17 commits into from
Aug 17, 2021

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Aug 2, 2021

also fixes test runner about exit status codes for gh actions to work properly

adds padded-blocks: 'never' for consistency of block newlines

fixes #894

@srknzl srknzl added this to the 5.0 milestone Aug 2, 2021
@srknzl srknzl requested a review from mdumandag August 2, 2021 11:35
@srknzl srknzl self-assigned this Aug 2, 2021
@srknzl srknzl changed the title Document and Validate Properties API-668 Document and Validate Properties Aug 2, 2021
DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
src/config/ConfigBuilder.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, despite this failure, the Github Actions report the tests are passed

  1624 passing (23m)
  73 pending
  1 failing

  1) ConfigBuilderTest
       properties:
     AssertionError: expected -1 to equal 'OFF'
      at Context.<anonymous> (test/unit/config/ConfigBuilderTest.js:155:61)

You should probably check that out

DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
src/config/Config.ts Outdated Show resolved Hide resolved
@srknzl
Copy link
Member Author

srknzl commented Aug 10, 2021

verify

Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one thing, it looks good

src/config/Config.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6d0fc42). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1001   +/-   ##
=========================================
  Coverage          ?   92.29%           
=========================================
  Files             ?      432           
  Lines             ?    16717           
  Branches          ?     1037           
=========================================
  Hits              ?    15429           
  Misses            ?     1019           
  Partials          ?      269           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d0fc42...7628daa. Read the comment docs.

@srknzl srknzl merged commit 19cc638 into hazelcast:master Aug 17, 2021
harunalpak pushed a commit to harunalpak/hazelcast-nodejs-client that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation regarding properties
3 participants