Record list of paths to type check#151
Merged
hauntsaninja merged 2 commits intomasterfrom Apr 18, 2025
Merged
Conversation
Supersedes #135 This PR should be a no-op, but I'll also go through the "{pyright}" cases as well
Owner
Author
|
cc @sharkdp |
Collaborator
|
Thank you very much, both for accepting this change at all, and for improving it! |
sharkdp
added a commit
to astral-sh/ruff
that referenced
this pull request
Apr 22, 2025
## Summary Switch to the official version of [`mypy_primer`](https://github.com/hauntsaninja/mypy_primer), now that Red Knot support has been upstreamed (see hauntsaninja/mypy_primer#138, hauntsaninja/mypy_primer#135, hauntsaninja/mypy_primer#151, hauntsaninja/mypy_primer#155). ## Test Plan Locally and in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #135
This PR should be a no-op, but I'll later go through the cases not touched here to make sure we have good coverage on
pathsfor red knotUsing templating is a little bit more explicit / boilerplate-y than the original PR, but keeps customisation easy