[red-knot] mypy_primer: Use upstream repo#17500
Merged
Conversation
sharkdp
added
ci
Contributor
|
sharkdp
force-pushed
the
david/mypy_primer-use-upstream-repo
branch
2 times, most recently
from
120892e to
af3cdf4
Compare
sharkdp
commented
Apr 22, 2025
| @@ -1,8 +1,6 @@ | |||
| arrow | |||
Contributor
Author
There was a problem hiding this comment.
This package is not included upstream. I used it for testing something, I don't think it's important that we keep it.
sharkdp
commented
Apr 22, 2025
| python-htmlgen | ||
| rich | ||
| scrapy | ||
| strawberry |
Contributor
Author
There was a problem hiding this comment.
I added this package in our fork, as it made use of @dataclass_transform. I'll propose to add this upstream.
Contributor
Author
There was a problem hiding this comment.
sharkdp
force-pushed
the
david/mypy_primer-use-upstream-repo
branch
from
af3cdf4 to
f1a91dc
Compare
sharkdp
requested review from
AlexWaygood,
MichaReiser,
carljm and
dcreager
as code owners
dcreager
added a commit
that referenced
this pull request
Apr 22, 2025
* main: (37 commits) [red-knot] Add list of failing/slow ecosystem projects (#17474) [red-knot] mypy_primer: extend ecosystem checks (#17544) [red-knot] Move `InstanceType` to its own submodule (#17525) [red-knot] mypy_primer: capture backtraces (#17543) [red-knot] mypy_primer: Use upstream repo (#17500) [red-knot] `typing.dataclass_transform` (#17445) Update dependency react-resizable-panels to v2.1.8 (#17513) Update dependency smol-toml to v1.3.3 (#17505) Update dependency uuid to v11.1.0 (#17517) Update actions/setup-node action to v4.4.0 (#17514) [red-knot] Fix variable name (#17532) [red-knot] Add basic subtyping between class literal and callable (#17469) [`pyupgrade`] Add fix safety section to docs (`UP030`) (#17443) [`perflint`] Allow list function calls to be replaced with a comprehension (`PERF401`) (#17519) Update pre-commit dependencies (#17506) [red-knot] Simplify visibility constraint handling for `*`-import definitions (#17486) [red-knot] Detect (some) invalid protocols (#17488) [red-knot] Correctly identify protocol classes (#17487) Update dependency ruff to v0.11.6 (#17516) Update Rust crate shellexpand to v3.1.1 (#17512) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch to the official version of
mypy_primer, now that Red Knot support has been upstreamed (see hauntsaninja/mypy_primer#138, hauntsaninja/mypy_primer#135, hauntsaninja/mypy_primer#151, hauntsaninja/mypy_primer#155).Test Plan
Locally and in CI