Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Robust tests #1413

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Robust tests #1413

merged 5 commits into from
Oct 16, 2019

Conversation

alanz
Copy link
Collaborator

@alanz alanz commented Oct 15, 2019

On certain machines (such as mine), when stack executes the tests we get additional window/ShowMessage messages sent about loading a package environment.

Adjust the matchers in the tests to allow these to be there, without failing the tests.

@alanz alanz requested review from lukel97 and fendor October 15, 2019 20:45
@alanz alanz requested a review from lorenzo October 15, 2019 20:46
Copy link
Collaborator

@lukel97 lukel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will open an issue to just add an "ignore logging notifications" config setting in lsp-test, or something to that affect, this seems quite painful

@lukel97
Copy link
Collaborator

lukel97 commented Oct 15, 2019

Once again you've already beaten me to it lol lukel97/lsp-test#53

@jneira jneira removed their assignment Oct 16, 2019
@alanz alanz merged commit 414bbee into haskell:master Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants