Skip to content
This repository has been archived by the owner on Mar 22, 2021. It is now read-only.

Add skipManyInterleavedTill combinator #53

Closed
alanz opened this issue Oct 12, 2019 · 3 comments
Closed

Add skipManyInterleavedTill combinator #53

alanz opened this issue Oct 12, 2019 · 3 comments

Comments

@alanz
Copy link
Contributor

alanz commented Oct 12, 2019

At the moment I have the completion tests in my local environment failing for hie, due to

_ <- skipManyTill loggingNotification (count 2 noDiagnostics)

which in my case receives a diagnostics notification, then a logging notification, then the second diagnostic.

What I actually want to say is skip any logging notifications until we have received two diagnostics notifications.

Is this currently possible? If not, we should make it so.

@alanz
Copy link
Contributor Author

alanz commented Oct 12, 2019

I guess it can be emulated by

    _ <- count 2 $ skipManyTill loggingNotification (count 1 noDiagnostics)

so perhaps does not need to be anything special. But it does come up in a lot of tests.

@lukel97
Copy link
Owner

lukel97 commented Oct 15, 2019

I think that can be shortened to

_ <- count 2 $ skipManyTill loggingNotification noDiagnostics

But at this point I think it is worthwhile just looking into a config option to just ignore all logging notifications, for practicality's sake

@lukel97
Copy link
Owner

lukel97 commented Nov 26, 2019

Closed in cb75f57

@lukel97 lukel97 closed this as completed Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants