Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Report progress when setting up cradle #644

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

lukel97
Copy link
Collaborator

@lukel97 lukel97 commented Jun 16, 2020

To do this we pass in the withProgress and withIndefiniteProgress functions from LspFuncs into ShakeExtras

Supersedes #627

To do this we pass in the withProgress and withIndefiniteProgress
functions from LspFuncs into ShakeExtras
@lukel97
Copy link
Collaborator Author

lukel97 commented Jun 16, 2020

Test failure looks kind of flaky, can someone rerun it?

@cocreature
Copy link
Collaborator

Restarted, 8.10 is pretty broken on Windows. Should probably just add some retries.

Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@cocreature cocreature merged commit 71631d8 into haskell:master Jun 17, 2020
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
To do this we pass in the withProgress and withIndefiniteProgress
functions from LspFuncs into ShakeExtras
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
To do this we pass in the withProgress and withIndefiniteProgress
functions from LspFuncs into ShakeExtras
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
To do this we pass in the withProgress and withIndefiniteProgress
functions from LspFuncs into ShakeExtras
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants