-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show "Progress: x/y" messages until the session/cradle has been setup #752
Comments
Just blame Pepe Iborra 😂 |
Jokes aside, can we inform the lsp client about the relative priorities of these progress messages, so that it will show the initialisation progress in the status bar, rather than the shake progress? |
@pepeiborra lol, I was wondering that as well though since it would be nice to not touch the shake progress. The state machine thing is set up quite nicely, and from what I can understand multiple sessions can be set up at once so I don't want to have to do loads of bookkeeping. Alas there doesn't seem to be anything in the specification for priority |
What if we keep sending initialisation progress messages every 100ms or so? Will that help? |
Does it continue being relevant, given changes in progress reporting since the opening of the issue? |
I haven't seen people complaining about this, and IMO this is a client issue anyway. We should be able to have multiple open progress sessions without a problem! |
Currently the progress message from haskell/ghcide#644 gets shadowed by the Shake reporting messages that say "Progress: ½", an example is in this link: https://streamable.com/nqbcfk
It would probably be more clear to the user if we hold off sending the work done progress report until the session is finished setting up.
The text was updated successfully, but these errors were encountered: