Revert workaround to filter JavaScriptFFI out on GHC versions where G… #8979
Conversation
…HC issue 11214 is fixed.
|
@JoshMeredith Hi! Is this something that you plan on backporting to the other minor releases? Will we have to perform a version check on GHC from cabal-install to make sure that the caller's GHC has incorporated your patch? |
|
No current plans for this to be backported in GHC, so I believe the major version check I've included in this MR will have to stay around. The JavaScript backend doesn't actually use this language extension (it works without it), so there's not a strong need for this to be fixed in that way - but the existence of it is preventing the JavaScript backend from reaching full Cabal support. |
|
@JoshMeredith jolly good. Shall I let you put the "squash + merge me" label? |
|
@Kleidukos I'd be excited to add the label, but I'm not sure I have access to do so |
mergify
bot
added
the
merge delay passed
|
@mergify backport 3.10 |
✅ Backports have been created
|
#8979) * Revert workaround to filter JavaScriptFFI out on GHC versions where GHC issue 11214 is fixed. * Lint * Lint * Update version range to reflect the fix being included in GHC 9.8 --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 8c9a71e) # Conflicts: # Cabal/src/Distribution/Simple/GHC.hs
Revert workaround to filter JavaScriptFFI out on GHC versions where G… (backport #8979)
4 participants
A previous Cabal MR (#3997) added a workaround for GHC incorrectly returning
JavaScriptFFIin the list ofghc --supported-extensions(https://gitlab.haskell.org/ghc/ghc/-/issues/11214).With the upstreaming of GHCJS into the GHC JavaScript backend, this should be fixed in GHC (https://gitlab.haskell.org/ghc/ghc/-/merge_requests/10505) so that non-JavaScript targets don't returning this extension, allowing the workaround to be reverted in Cabal for newer GHC versions.