Workaround GHC #11214 by filtering JavaScriptFFI #3997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, "native" GHC advertises support for `JavaScriptFFI` even though it doesn't support it. See also https://ghc.haskell.org/ticket/11214 for respective bug. However, in order to properly declare that packages require `JavaScriptFFI` support via `other-extensions` we need to fixup the list of extensions fed to the cabal solver. This patch does something similiar to the workaround we added some time ago to filter out TemplateHaskell for older GHCs which didn't properly advertise `TemplateHaskell` availability (c.f. 9f68eb4)
Member
Author
Contributor
|
OK looks fine. A bit annoying that we can't test. |
Member
|
Merged, thanks! Also cherry-picked into 1.24 (0bae317). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, "native" GHC advertises support for
JavaScriptFFIeven thoughit doesn't support it. See also https://ghc.haskell.org/ticket/11214 for respective
bug.
However, in order to properly declare that packages require
JavaScriptFFIsupportvia
other-extensionswe need to fixup the list of extensions fed to the cabal solver.This patch does something similiar to the workaround we added some time ago to
filter out TemplateHaskell for older GHCs which didn't properly advertise
TemplateHaskellavailability (c.f. 9f68eb4)