Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal-validate: Some steps shouldn't be steps #10570

Open
9999years opened this issue Nov 20, 2024 · 0 comments · May be fixed by #10573
Open

cabal-validate: Some steps shouldn't be steps #10570

9999years opened this issue Nov 20, 2024 · 0 comments · May be fixed by #10573
Labels
cabal-validate validate.sh (cabal-validate) test suite runner meta: tracking re: devx Improving the cabal developer experience (internal issue) type: testing Issues about project test suites

Comments

@9999years
Copy link
Collaborator

print-config, print-tool-versions, and time-summary aren't really steps in the sense that they run commands with side-effects, they just print informative output for the user.

There's two issues with this:

  1. ./validate.sh with no arguments clutters the output with a bunch of mostly-useless information.
  2. If you pass any steps explicitly, like ./validate.sh -s cli-suite, configuration information and a summary of how long it took to run all the steps will be skipped.

Proposal: Configuration information and a time summary should be displayed (or not displayed, depending on --verbose) regardless of what steps are given.

@9999years 9999years added meta: tracking re: devx Improving the cabal developer experience (internal issue) type: testing Issues about project test suites cabal-validate validate.sh (cabal-validate) test suite runner labels Nov 20, 2024
9999years added a commit to 9999years/cabal that referenced this issue Nov 20, 2024
`print-config`, `print-tool-versions`, and `time-summary` are no longer
explicit steps, and are instead run implicitly (closes haskell#10570).

`time-summary` is redundant in its current form and is removed. It may
be added back in the future with more detailed output (e.g., which steps
were run, how long did they take individually).

`print-config` and `print-tool-versions` are hidden unless `--verbose`
is given.
@9999years 9999years linked a pull request Nov 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cabal-validate validate.sh (cabal-validate) test suite runner meta: tracking re: devx Improving the cabal developer experience (internal issue) type: testing Issues about project test suites
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant