Certificate name validation #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* a wildcard matches only one level of subdomains * hostname matching is now case-insensitive Fixes snoyberg/http-client#212.
|
Related to haskell-tls/hs-tls#163. |
|
Thanks. looking good, although the general validation sorely lack automated testing |
This was referenced Oct 2, 2016
oherrala
added a commit
to ouspg/trytls
that referenced
this pull request
Oct 2, 2016
Two good things merged into x509 package worth mentioning: * Certificate bundle reading was merged from pull request haskell-tls/hs-certificate#71 * Certificate name validation was merged from pull request haskell-tls/hs-certificate#75
|
OK, I'll see if I can add a test suite to x509-validation to test expected validation results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request changes domain name matching in
x509-validationto get closer to other implementations and RFCs :Case conversion is performed directly in
splitDot, and the function call is now moved intomatchDomainso that the original name before conversion can be returned insideInvalidName.A wildcard is supported only for the left-most component just like before. I didn’t consider extending this or supporting component fragments like
f*o.example.combecause this is more complex and probably never used in practice (discussed somehow in RFC 6125 §7.2).