Read file or directory into CertificateStore #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oherrala
added a commit
to ouspg/trytls
that referenced
this pull request
Jul 11, 2016
This is first Haskell stub to support custom CA bundles given by TryTLS runner. It required modification to Haskell's x509-store package. Pull request about it can be found here: haskell-tls/hs-certificate#71
oherrala
added a commit
to ouspg/trytls
that referenced
this pull request
Jul 21, 2016
This is first Haskell stub to support custom CA bundles given by TryTLS runner. It required modification to Haskell's x509-store package. Pull request about it can be found here: haskell-tls/hs-certificate#71
…tore This is 100% code copied from System.X509.Unix and some documentation added. This allows x509-store package user to specify custom file or directory to read certificates from. The use case I'm considering is reading custom CA certificate bundle.
Reading certificates from file or directory is useful (for example for reading custom CA certificate bundles), so promote these functions into Data.X509.CertificateStore.
oherrala
added a commit
to ouspg/trytls
that referenced
this pull request
Oct 2, 2016
Two good things merged into x509 package worth mentioning: * Certificate bundle reading was merged from pull request haskell-tls/hs-certificate#71 * Certificate name validation was merged from pull request haskell-tls/hs-certificate#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves functions from
System.X509.UnixintoData.X509.CertificateStoreand exportsData.X509.CertificateStore.readCertificateStore :: FilePath -> IO (Maybe CertificateStore).readCertificateStorereads given path (file or directory) intoCertificateStore. This makes it easy and convenient to read CA bundle files.System.X509.Unixis also modified to useData.X509.CertificateStore.readCertificateStore.