Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Go/NodeJS OS/arch translation logic #532

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

radeksimko
Copy link
Member

This will allow installation of solaris builds and linux/arm64 when it's published: hashicorp/terraform-ls#351

@radeksimko radeksimko requested a review from a team January 4, 2021 20:50
appilon
appilon previously approved these changes Jan 5, 2021
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left my 0.02$ but nothing explicitly wrong, LGTM

@radeksimko radeksimko merged commit 1bb5ed1 into master Jan 5, 2021
@radeksimko radeksimko deleted the extract-os-arch-funcs branch January 5, 2021 16:05
@ghost
Copy link

ghost commented Feb 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants