Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linux/arm64 #351

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Add support for linux/arm64 #351

merged 2 commits into from
Jan 5, 2021

Conversation

radeksimko
Copy link
Member

This mimics build targets of latest Terraform (core) version, e.g.
https://releases.hashicorp.com/terraform/0.14.3/

Closes #342

@radeksimko radeksimko added the ci Continuous integration/delivery related label Jan 4, 2021
@radeksimko radeksimko requested a review from a team January 4, 2021 18:43
- goarch: arm64
goos: openbsd
- goarch: arm64
goos: freebsd
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure whether the above 3 combinations are ignored intentionally, or by accident as they aren't explicitly mentioned here https://github.com/hashicorp/terraform/blob/c0e37a7ea1928918a9efc02290ecd241d396d3a6/scripts/build.sh#L20 but gox doesn't support them:
https://github.com/mitchellh/gox/blob/master/platform.go

Either way there is no point in providing LS builds if there is no corresponding Terraform build, so I opted to ignore these. 🤷🏻‍♂️

Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit b5d221d into main Jan 5, 2021
@radeksimko radeksimko deleted the linux_arm64 branch January 5, 2021 08:03
@ghost
Copy link

ghost commented Feb 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM64 support/package creation
2 participants