Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy button in collapsed sidebar nav in CopyButton component #23511

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

Monkeychip
Copy link
Contributor

This is more or less a manual backport but with changes because we don't have the HDS copy button in 1.15. See original PR here.

@Monkeychip Monkeychip added this to the 1.15.1 milestone Oct 4, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Build Results:
All builds succeeded! ✅

@@ -39,12 +39,13 @@
</LinkTo>
</li>
{{/if}}
<li class="action">
<li class="action" id="container">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I'd probably be more specific in the future. Something like copy-token-action - we don't want to accidentally introduce any naming collisions (ids have to be unique, so I think linter catches that, but just my two cents!)

@Monkeychip Monkeychip merged commit afd9d0b into release/1.15.x Oct 8, 2023
@Monkeychip Monkeychip deleted the ui/fix-copy-root-pre-hds-copy-button branch October 8, 2023 19:09
Monkeychip added a commit that referenced this pull request Oct 8, 2023
Monkeychip added a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants