Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Copy token button when sidebar navigation is in a collapsed state due to a small window size #23331

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Sep 27, 2023

Addressing the navbar issue when in a collapsed state you are not able to copy a token.

Note: there are still two other collapsed navbar issues (namespace picker and the console) but those are larger fixes and need more research.

Backported to 1.14 when navbar work was released.

@Monkeychip Monkeychip added ui bug Used to indicate a potential bug labels Sep 27, 2023
@Monkeychip Monkeychip added this to the 1.14.5 milestone Sep 27, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 27, 2023
@Monkeychip Monkeychip marked this pull request as ready for review October 3, 2023 22:01
@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
vault ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 10:07pm

@Monkeychip Monkeychip changed the title WIP Fix Copy token button when sidebar navigation is in a collapsed state due to a small window size Oct 3, 2023
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! I wonder if this issue could be recreated in an acceptance test? If so it might be worth adding coverage.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants