Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix list on password policies to list the policies containing slashes into release/1.12.x #23172

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #23155 to be assessed for backporting due to the inclusion of the label backport/1.12.x.

The below text is copied from the body of the original PR.


Issue: #17117
Slack conversation: https://hashicorp.slack.com/archives/C0287E435NE/p1694714032988359
Jira: https://hashicorp.atlassian.net/browse/VAULT-20052

Vault allows us to create password policies with "/" similar to other policy types like acl
Example: vault write sys/policies/password/example/example1 policy=@example_policy.hcl is allowed

but the list on password policies does not list the values after "/"
Example response: {"request_id":"9b1eadda-0511-02e0-f17f-7b9fe1d2c8b7","lease_id":"","renewable":false,"lease_duration":0,"data":{"keys":["example/"]},"wrap_info":null,"warnings":null,"auth":null}

Making this work consistently with acl policies. This fix produces the following response:
{"request_id":"9b1eadda-0511-02e0-f17f-7b9fe1d2c8b7","lease_id":"","renewable":false,"lease_duration":0,"data":{"keys":["example/example1"]},"wrap_info":null,"warnings":null,"auth":null}


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/vault-20052-oss/radically-infinite-mosquito branch 2 times, most recently from 1768979 to 7736f12 Compare September 19, 2023 19:28
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 19, 2023
@akshya96 akshya96 enabled auto-merge (squash) September 19, 2023 19:29
@akshya96 akshya96 disabled auto-merge September 19, 2023 19:30
@akshya96 akshya96 closed this Sep 19, 2023
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants