Fix list on password policies to list the policies containing slashes #23155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
akshya96
requested review from
a team and
hc-github-team-secure-vault-core
and removed request for
a team
biazmoreira
approved these changes
Sep 19, 2023
mpalmi
reviewed
Sep 19, 2023
| @@ -4739,6 +4739,26 @@ func TestHandlePoliciesPasswordList(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| "policy with /": { | |||
There was a problem hiding this comment.
It'd be nice to see a test with another level of paths, similar to the example included in the associated issue (path/to/policy).
There was a problem hiding this comment.
Also curious to see what happens if our policy ends in /.
There was a problem hiding this comment.
Added tests for these two cases listed above
This was referenced Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #17117
Slack conversation: https://hashicorp.slack.com/archives/C0287E435NE/p1694714032988359
Jira: https://hashicorp.atlassian.net/browse/VAULT-20052
Vault allows us to create password policies with "/" similar to other policy types like acl
Example: vault write sys/policies/password/example/example1 policy=@example_policy.hcl is allowed
but the list on password policies does not list the values after "/"
Example response: {"request_id":"9b1eadda-0511-02e0-f17f-7b9fe1d2c8b7","lease_id":"","renewable":false,"lease_duration":0,"data":{"keys":["example/"]},"wrap_info":null,"warnings":null,"auth":null}
Making this work consistently with acl policies. This fix produces the following response:
{"request_id":"9b1eadda-0511-02e0-f17f-7b9fe1d2c8b7","lease_id":"","renewable":false,"lease_duration":0,"data":{"keys":["example/example1"]},"wrap_info":null,"warnings":null,"auth":null}