Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1.7.x: Raft peer removal bug #13214

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Backport 1.7.x: Raft peer removal bug #13214

merged 4 commits into from
Jan 25, 2022

Conversation

zofskeez
Copy link
Contributor

No description provided.

@zofskeez
Raft peer removal bug (#13098)
4fb699f 
* fixes issue removing raft peer via cli not reflected in UI until refresh

* adds changelog entry
@zofskeez zofskeez added this to the 1.7.7 milestone Nov 18, 2021
@mladlow mladlow modified the milestones: 1.7.7, 1.7.8 Dec 9, 2021
@mladlow
Copy link
Collaborator

mladlow commented Dec 13, 2021

@zofskeez are we looking to get this and its other backports merged soon so they go into a release?

@zofskeez
Copy link
Contributor Author

@zofskeez are we looking to get this and its other backports merged soon so they go into a release?

@mladlow Chelsea had concerns approving these backport PR's since a new dependency was added. I will loop up with her when she is back to confirm how to proceed.

@mladlow
Copy link
Collaborator

mladlow commented Dec 14, 2021

Thanks! I'll just bump out the milestones then.

@mladlow mladlow modified the milestones: 1.7.8, 1.7.9 Dec 14, 2021
@mladlow
Copy link
Collaborator

mladlow commented Jan 24, 2022

@zofskeez or @chelshaw is this still planned for 1.7? If we're worried about the dependency updates we could decide to not backport it to 1.7, I think, and just close this PR?

@mladlow mladlow removed this from the 1.7.9 milestone Jan 24, 2022
@zofskeez
Copy link
Contributor Author

@mladlow I spoke with @chelshaw and since the original ticket mentioned 1.7.0 and 1.7.5 as versions the bug was reproduced in we will keep this backport. I'm working on refactoring the test right now to not use the added dependency. This should be ready to merge later today.

@vercel vercel bot temporarily deployed to Preview – vault January 25, 2022 17:50 Inactive
@vercel vercel bot temporarily deployed to Preview – vault January 25, 2022 17:51 Inactive
hashishaw
hashishaw approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zofskeez zofskeez added this to the 1.7.9 milestone Jan 25, 2022
@zofskeez zofskeez merged commit 43a071e into release/1.7.x Jan 25, 2022
@zofskeez zofskeez deleted the backport-pr-13098-1.7.x branch January 25, 2022 20:13
@mladlow
Copy link
Collaborator

mladlow commented Jan 25, 2022

Great! Always good to get this stuff in. I'm going to assign it the 1.7.10 milestone though, because we have the SHAs set for 1.7.9, 1.8.8, and 1.9.3.

@mladlow mladlow modified the milestones: 1.7.9, 1.7.10 Jan 25, 2022
@zofskeez
Copy link
Contributor Author

Ok thanks! Sorry it took so long to get the issue sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.10
Development

Successfully merging this pull request may close these issues.
3 participants
@zofskeez @mladlow @hashishaw