Raft peer removal bug #13098
Merged
Raft peer removal bug #13098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zofskeez
added a commit
that referenced
this pull request
Nov 18, 2021
* fixes issue removing raft peer via cli not reflected in UI until refresh * adds changelog entry
zofskeez
added a commit
that referenced
this pull request
Nov 18, 2021
* fixes issue removing raft peer via cli not reflected in UI until refresh * adds changelog entry
zofskeez
added a commit
that referenced
this pull request
Nov 18, 2021
* fixes issue removing raft peer via cli not reflected in UI until refresh * adds changelog entry
zofskeez
added a commit
that referenced
this pull request
Jan 25, 2022
* Raft peer removal bug (#13098) * fixes issue removing raft peer via cli not reflected in UI until refresh * adds changelog entry * removes faker * attempts to fix global error in circle ci run
zofskeez
added a commit
that referenced
this pull request
Jan 25, 2022
* Raft peer removal bug (#13098) * fixes issue removing raft peer via cli not reflected in UI until refresh * adds changelog entry * removes faker * attempts to fix global error in circle ci run
zofskeez
added a commit
that referenced
this pull request
Jan 25, 2022
* Raft peer removal bug (#13098) * fixes issue removing raft peer via cli not reflected in UI until refresh * adds changelog entry * removes faker * attempts to fix global error in circle ci run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing a raft storage peer from the cluster via the CLI, the UI would not reflect the change until the page was refreshed. The findAll method returns everything from the store, which in this case included stale records since they were removed externally. After updating to use the query method, only records from the response are returned.
Testing
vault operator raft remove-peer name_of_raft_node