Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker provision centos8 #11462

Merged
merged 8 commits into from
Apr 13, 2020
Merged

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Mar 25, 2020

addresses: #11330

soapy1 added 2 commits March 25, 2020 10:36
containerd.io is required for docker howerver it is not avilable
in official yum repos. It needs to be installed directly from
docker.

ref:
https://docs.docker.com/install/linux/docker-ce/centos/
https://linuxconfig.org/how-to-install-docker-in-rhel-8
@@ -12,6 +12,8 @@ def self.flavor(machine)
# Detect various flavors we care about
if output =~ /(CentOS|Red Hat Enterprise|Scientific|Cloud|Virtuozzo)\s*Linux( .+)? release 7/i
return :rhel_7
elsif output =~ /(CentOS|Red Hat Enterprise|Scientific|Cloud|Virtuozzo)\s*Linux( .+)? release 8/i
return :rhel_8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will close #11453 👍

@@ -4,10 +4,15 @@ module Cap
module Redhat
module DockerInstall
def self.docker_install(machine)
if machine.guest.capability("flavor") == :rhel_8
machine.ui.warn("Docker is not supported on RHEL 8 machines.")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably also provide a link to an article that instructs a user how to get around this. Or could suggest they do something like use the podman provisioner #11464

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Borrowing from the get.docker.com script slightly, I think we could say something like:

RHEL is now only supported by Docker EE. Please install Docker EE or switch to the Podman provisioner to run containers on RHEL.

Does this apply to RHEL < 8 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ya that sounds better!

As far as I can tell, docker isn't supported on RHEL at all. Though the docker docs still have a guide for installing docker ce that works up until (and including) RHEL 7 https://docs.docker.com/install/linux/docker-ce/centos/#install-docker-engine---community.

Maybe the warning should be emitted for all RHEL systems and only hard fail on RHEL 8?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like Vagrant should not attempt to install Docker on RHEL:

  1. The docker-install script says it's not supported: https://github.com/docker/docker-install/blob/b50fac9805c3d95fb5e8b16d57b19d333e972e20/install.sh#L318
  2. Docker Engine - Community is not supported on Red Hat Enterprise Linux.

Folks who want to use Docker on RHEL can still install it themselves using a shell provisioner, since this seems to be pretty well documented.

@soapy1 soapy1 force-pushed the docker-provision-centos8 branch from 0b242c7 to d87d421 Compare April 1, 2020 19:06
soapy1 added 2 commits April 3, 2020 14:27
Docker CE is not supported on RHEL.
It is supported on CentOS
Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the updates look great! However, I think that with all this newly added logic for centos, we should probably just spin out a centos guest and relocate that logic into the new guest.

@soapy1 soapy1 force-pushed the docker-provision-centos8 branch from e19fb86 to ed24c82 Compare April 6, 2020 15:08
@soapy1 soapy1 force-pushed the docker-provision-centos8 branch from ed24c82 to e61725a Compare April 6, 2020 17:48
Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soapy1 soapy1 merged commit ee87596 into hashicorp:master Apr 13, 2020
@soapy1 soapy1 deleted the docker-provision-centos8 branch April 13, 2020 13:42
@ghost
Copy link

ghost commented May 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants