Add RHEL/CentOS 8 to list of RHEL flavors #11453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it so that `:rhel_8` will be returned on el8 guests.
|
|
dustymabe
added a commit
to dustymabe/vagrant-sshfs
that referenced
this pull request
Mar 15, 2020
See hashicorp/vagrant#11453. Here we add a compatibility function to handle :rhel_8 because otherwise we'd have to wait until a new version of vagrant got released and rolled out everywhere before our users could take advantage of this.
|
Hi @dustymabe, thanks for opening the PR! This looks fine, but I have two requests/suggestions:
Thanks again for the PR! 🎉 |
|
@dustymabe thank you for the PR! This has been superseded as part of the work in #11462 |
|
Thanks sorry I didn't have time to get back to this PR |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it so that
:rhel_8will be returned on el8guests.