provider/azurerm: write load_balanacer attributes to network_interface_card hash

[pmcatominey]

TF_ACC=1 go test ./builtin/providers/azurerm -v -run TestAccAzureRMNetworkInterface -timeout 120m
=== RUN   TestAccAzureRMNetworkInterface_basic
--- PASS: TestAccAzureRMNetworkInterface_basic (197.24s)
=== RUN   TestAccAzureRMNetworkInterface_enableIPForwarding
--- PASS: TestAccAzureRMNetworkInterface_enableIPForwarding (188.65s)
=== RUN   TestAccAzureRMNetworkInterface_withTags
--- PASS: TestAccAzureRMNetworkInterface_withTags (226.13s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    612.088s

[pmcatominey]

I noticed that this change was originally made in #6429

[stack72]

Hi @pmcatominey

I am going to wait until after #9199 to merge this - this sort of makes little sense unless the LB is implemented. sound ok?

P.

[pmcatominey]

@stack72 yep, that's fine.

[stack72]

while you are paying attention to my comments - any thoughts on why these are failing? https://travis-ci.org/hashicorp/terraform/jobs/164835834

Potential vendor dep issue?

[pmcatominey]

Looks like it, the time formatting in Azure/go-autorest was changed to fix a bug and made it into Terraform yesterday as part of #9151.

The original change landed in Azure/go-autorest#89 to fix the SDK issue (Azure/azure-sdk-for-go#402).

Seems that has introduced a regression which should be fixed as of Azure/go-autorest#91. We need Azure/azure-sdk-for-go#407 to be merged to catch this fix.

[stack72]

@pmcatominey just a FYI, I bumped go-autorest to 7.2.1 last night and the tests are now passing again

[stack72]

Thanks for the work here @pmcatominey - going to merge this now that LB has been merged

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.