This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Fix parsing of UTC times that are not RFC3339 conformant.#89
Merged
Conversation
Some APIs don't fully comply with RFC3339 and omit the time zone suffix which breaks unmarshaling. To work around this I have added another formatting for time parsing that omits the suffix.
Member
Author
Member
Author
Member
Author
|
This has been updated in the Go SDK repo see Azure/azure-sdk-for-go#405 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some APIs don't fully comply with RFC3339 and omit the time zone suffix
which breaks unmarshaling. To work around this I have added another
formatting for time parsing that omits the suffix.
Ideally the APIs should return proper RFC3339 time information, will
follow up on this separately.