Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REPACK] #452 providers/google: remove deprecated client secrets file #884

Merged
merged 2 commits into from
Jan 28, 2015
Merged

[REPACK] #452 providers/google: remove deprecated client secrets file #884

merged 2 commits into from
Jan 28, 2015

Commits on Jan 28, 2015

  1. providers/google: remove secrets file 

    fixes #452
    @stuntgoat @phinze
    stuntgoat authored and phinze committed Jan 28, 2015
    Configuration menu
    Copy the full SHA
    d3814d6 View commit details
    Browse the repository at this point in the history

  2. providers/google: fix instance creation 

    with this commit, the google compute instance acceptance tests are
passing

 - remove GOOGLE_CLIENT_FILE requirement from provider tests to finish
   out #452
 - skip extra "#" key that shows up in metadata maps, fixes #757 and
   sprouts #883 to figure out core issue
 - more verbose variablenames in metadata parsing, since it took me
   awhile to grok and i thought there might have been a shadowing bug in
   there for a minute. maybe someday when i'm a golang master i'll be
   smart enough to be comfortable with one-char varnames. :)
    @phinze
    phinze committed Jan 28, 2015
    Configuration menu
    Copy the full SHA
    9fff0b1 View commit details
    Browse the repository at this point in the history