helper/schema: list of maps read from config yields extra '#' field in map #883
Comments
phinze
added a commit
that referenced
this issue
Jan 28, 2015
with this commit, the google compute instance acceptance tests are passing - remove GOOGLE_CLIENT_FILE requirement from provider tests to finish out #452 - skip extra "#" key that shows up in metadata maps, fixes #757 and sprouts #883 to figure out core issue - more verbose variablenames in metadata parsing, since it took me awhile to grok and i thought there might have been a shadowing bug in there for a minute. maybe someday when i'm a golang master i'll be smart enough to be comfortable with one-char varnames. :)
phinze
added a commit
that referenced
this issue
Feb 4, 2015
An `InstanceDiff` will include `ResourceAttrDiff` entries for the "length" / `#` field of maps. This makes sense, since for something like `terraform plan` it's useful to see when counts are changing. The `DiffFieldReader` was not taking these entries into account when reading maps out, and was therefore incorrectly returning maps that included an extra `'#'` field, which was causing all sorts of havoc for providers (extra tags on AWS instances, broken google compute instance launch, possibly others). * fixes #914 - extra tags on AWS instances * fixes #883 - general core issue sprouted from #757 * removes the hack+TODO from #757
yahyapo
pushed a commit
to yahyapo/terraform
that referenced
this issue
Mar 13, 2015
with this commit, the google compute instance acceptance tests are passing - remove GOOGLE_CLIENT_FILE requirement from provider tests to finish out hashicorp#452 - skip extra "#" key that shows up in metadata maps, fixes hashicorp#757 and sprouts hashicorp#883 to figure out core issue - more verbose variablenames in metadata parsing, since it took me awhile to grok and i thought there might have been a shadowing bug in there for a minute. maybe someday when i'm a golang master i'll be smart enough to be comfortable with one-char varnames. :)
yahyapo
pushed a commit
to yahyapo/terraform
that referenced
this issue
Mar 13, 2015
An `InstanceDiff` will include `ResourceAttrDiff` entries for the "length" / `#` field of maps. This makes sense, since for something like `terraform plan` it's useful to see when counts are changing. The `DiffFieldReader` was not taking these entries into account when reading maps out, and was therefore incorrectly returning maps that included an extra `'#'` field, which was causing all sorts of havoc for providers (extra tags on AWS instances, broken google compute instance launch, possibly others). * fixes hashicorp#914 - extra tags on AWS instances * fixes hashicorp#883 - general core issue sprouted from hashicorp#757 * removes the hack+TODO from hashicorp#757
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
comes out of #757, where i'm applying a very specific fix to short circuit my rabbit hole 🐰 🙅
The text was updated successfully, but these errors were encountered: