Skip to content

Conversation

@github-actions
Copy link
Contributor

Backport

This PR is auto-generated from #37645 to be assessed for backporting due to the inclusion of the label 1.14-backport.

The below text is copied from the body of the original PR.


Description

This PR provide the raw args to the StacksCommand's Help() which allows for the more typical -help usage rather than strictly requiring the -usage flag for command usage information.

We previously ran into trouble with the handling of the -help flag in regards to the the stacks CLI plugin. Notably since the cli runner strips the -help flag from the args passed to the command's Run implementation. At the time we encountered this we opted for a stop gap solution of using the -usage flag for help texts. This PR at adds the ability to properly handle the help flag.

Target Release

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

Overview of commits

@liamcervante liamcervante marked this pull request as ready for review September 23, 2025 06:25
@liamcervante liamcervante requested a review from a team as a code owner September 23, 2025 06:25
@dbanck dbanck merged commit 2434b31 into v1.14 Sep 24, 2025
7 checks passed
@dbanck dbanck deleted the backport/handle-help-usage-stacks-plugin/broadly-fleet-gecko branch September 24, 2025 13:36
@github-actions
Copy link
Contributor Author

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants