Skip to content

Conversation

@Maed223
Copy link
Contributor

@Maed223 Maed223 commented Sep 19, 2025

Description

This PR provide the raw args to the StacksCommand's Help() which allows for the more typical -help usage rather than strictly requiring the -usage flag for command usage information.

We previously ran into trouble with the handling of the -help flag in regards to the the stacks CLI plugin. Notably since the cli runner strips the -help flag from the args passed to the command's Run implementation. At the time we encountered this we opted for a stop gap solution of using the -usage flag for help texts. This PR at adds the ability to properly handle the help flag.

Target Release

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@Maed223 Maed223 requested a review from a team as a code owner September 19, 2025 15:46
@Maed223 Maed223 added 1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.13-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged and removed 1.3-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Sep 19, 2025
@Maed223 Maed223 force-pushed the handle-help-usage-stacks-plugin branch 5 times, most recently from 7e1218c to a1ad8b5 Compare September 19, 2025 19:47
@Maed223 Maed223 added 1.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged and removed 1.13-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Sep 19, 2025
@Maed223 Maed223 force-pushed the handle-help-usage-stacks-plugin branch from a1ad8b5 to 7f0ef4c Compare September 19, 2025 19:50
@Maed223 Maed223 merged commit f8b0051 into main Sep 22, 2025
11 checks passed
@Maed223 Maed223 deleted the handle-help-usage-stacks-plugin branch September 22, 2025 13:54
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants