internal/schema: Replace TupleConsExpr with SetExpr

[radeksimko]

Part of hashicorp/terraform-ls#496

The attributes in question will never be treated as data, so the data type doesn't really matter as much in this context. The main effect is hints in the completion and hover data.

Set seems most appropriate of all options (list, set, tuple), given that every element is of the same type (which rules out tuple) and order of elements doesn't matter (which rules out list).

---

The attributes in question will never be treated as data, so the data type doesn't really matter as much in this context. The main effect is hints in the completion and hover data.

Set seems most appropriate of all options (list, set, tuple), given that every element is of the same type (which rules out tuple) and order of elements doesn't matter (which rules out list).

---

UX Impact

(This implies hashicorp/hcl-lang#175 also in effect)

This has some relatively minor side effects in the completion and hover UX. One is mostly positive (experiments) and others are still okay (displaying singular instead of plural).

We can discuss whether the singular/plural thing is worth addressing and what the best version is there, but the PR is mainly meaning to solve the bug which is mis-rendering multiple constraints under collection types.

Also I am not sure if using more concrete description of a type, such as experiment is actually more helpful than just keyword. 🤷🏻

Before

After

[dbanck]

Thanks for outlining the UX differences.

I think we don't need to change anything about the singular/plural wording. The expression wording is now more in line with the existing wording on other attributes/types.