Remove schema.TupleConsExpr
#175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-remove-tupleconsexpr
branch
from
994419f
to
70eba5f
Compare
radeksimko
force-pushed
the
f-remove-tupleconsexpr
branch
from
70eba5f
to
4e85a75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-ls#496
Related
terraform-schemaPR: hashicorp/terraform-schema#169Originally the
TupleConsExprconstraint was meaning to express the "raw" HCLTupleConsExpr(essentially the[]square brackets) in context where the expression isn't interpreted as data.However, as we will be making some bigger changes to expressions, this additional constraint is something we'd have to account for too, when we can instead just use any of the existing types, such as
ListExpr,SetExprorTupleExpr, on best-effort basis to express how the expression is treated and reduce the total number of constraints we have to deal with.For example, in Terraform's
dataorresourceblock, we havedepends_on = []. We can chooseSetExprwith the reasoning that ordering of elements within doesn't matter and every element is of the same type.hashicorp/terraform-schema#169 also uncovered one minor bug with rendering of collections types with multiple element constraints, so I added some more tests and fixed the bug.