deprecate ad secret resources

CHANGELOG.md

@@ -1,3 +1,21 @@
+## 3.15.2 (May 3, 2023)
+BUGS:
+* Revert [#1830](https://github.com/hashicorp/terraform-provider-vault/pull/1830) which introduced a unexpected breaking change in the way authentication is done within a namespace: ([#1840](https://github.com/hashicorp/terraform-provider-vault/pull/1840))
+
+## 3.15.1 (May 3, 2023)
+BUGS:
+* Ensure that the auth_login honours the provider's namespace: ([#1830](https://github.com/hashicorp/terraform-provider-vault/pull/1830))
+
+## 3.15.0 (April 17, 2023)
+FEATURES:
+* Add support for MongoDB Atlas Secrets engine: ([#1816](https://github.com/hashicorp/terraform-provider-vault/pull/1816))
+
+BUGS:
+* Fix panic while importing namespaces: ([#1818](https://github.com/hashicorp/terraform-provider-vault/pull/1818))
+* Avoid writing empty strings to Vault when creating PKCS managed keys: ([#1803](https://github.com/hashicorp/terraform-provider-vault/pull/1803))
+* Fix possible panic with autopilot import: ([#1801](https://github.com/hashicorp/terraform-provider-vault/pull/1801))
+* Ensure that the `qr_size` can be properly configured for MFA TOTP: ([#1750](https://github.com/hashicorp/terraform-provider-vault/pull/1750))
+
 ## 3.14.0 (March 15, 2023)
 FEATURES:
 * Add PKI Unified CRL parameters: ([#1789](https://github.com/hashicorp/terraform-provider-vault/pull/1789))

vault/data_source_ad_credentials.go

@@ -14,7 +14,8 @@ import (
 
 func adAccessCredentialsDataSource() *schema.Resource {
 	return &schema.Resource{
-		Read: ReadWrapper(readCredsResource),
+		DeprecationMessage: `This data source is replaced by "vault_ldap_static_credentials" and will be removed in the next major release.`,
+		Read:               ReadWrapper(readCredsResource),
 		Schema: map[string]*schema.Schema{
 			"backend": {
 				Type:        schema.TypeString,

vault/resource_ad_secret_backend.go

@@ -213,10 +213,11 @@ func adSecretBackendResource() *schema.Resource {
 		},
 	}
 	return provider.MustAddMountMigrationSchema(&schema.Resource{
-		Create: createConfigResource,
-		Update: updateConfigResource,
-		Read:   ReadWrapper(readConfigResource),
-		Delete: deleteConfigResource,
+		DeprecationMessage: `This resource is replaced by "vault_ldap_secret_backend" and will be removed in the next major release.`,
+		Create:             createConfigResource,
+		Update:             updateConfigResource,
+		Read:               ReadWrapper(readConfigResource),
+		Delete:             deleteConfigResource,
 		Importer: &schema.ResourceImporter{
 			State: schema.ImportStatePassthrough,
 		},

vault/resource_ad_secret_library.go

@@ -63,10 +63,11 @@ func adSecretBackendLibraryResource() *schema.Resource {
 		},
 	}
 	return &schema.Resource{
-		Create: createLibraryResource,
-		Update: updateLibraryResource,
-		Read:   ReadWrapper(readLibraryResource),
-		Delete: deleteLibraryResource,
+		DeprecationMessage: `This resource is replaced by "vault_ldap_secret_backend_library_set" and will be removed in the next major release.`,
+		Create:             createLibraryResource,
+		Update:             updateLibraryResource,
+		Read:               ReadWrapper(readLibraryResource),
+		Delete:             deleteLibraryResource,
 		Importer: &schema.ResourceImporter{
 			State: schema.ImportStatePassthrough,
 		},

vault/resource_ad_secret_roles.go

@@ -59,10 +59,11 @@ func adSecretBackendRoleResource() *schema.Resource {
 		},
 	}
 	return &schema.Resource{
-		Create: createRoleResource,
-		Update: updateRoleResource,
-		Read:   ReadWrapper(readRoleResource),
-		Delete: deleteRoleResource,
+		DeprecationMessage: `This resource is replaced by "vault_ldap_secret_backend_static_role" and will be removed in the next major release.`,
+		Create:             createRoleResource,
+		Update:             updateRoleResource,
+		Read:               ReadWrapper(readRoleResource),
+		Delete:             deleteRoleResource,
 		Importer: &schema.ResourceImporter{
 			State: schema.ImportStatePassthrough,
 		},

vault/resource_okta_auth_backend.go

@@ -28,7 +28,6 @@ func oktaAuthBackendResource() *schema.Resource {
 		Delete: oktaAuthBackendDelete,
 		Read:   ReadWrapper(oktaAuthBackendRead),
 		Update: oktaAuthBackendUpdate,
-		Exists: oktaAuthBackendExists,
 		Importer: &schema.ResourceImporter{
 			State: schema.ImportStatePassthrough,
 		},
@@ -290,10 +289,6 @@ func oktaAuthBackendDelete(d *schema.ResourceData, meta interface{}) error {
 	return nil
 }
 
-func oktaAuthBackendExists(d *schema.ResourceData, meta interface{}) (bool, error) {
-	return isOktaAuthBackendPresent(meta.(*provider.ProviderMeta).GetClient(), d.Id())
-}
-
 func oktaAuthBackendRead(d *schema.ResourceData, meta interface{}) error {
 	client, e := provider.GetClient(d, meta)
 	if e != nil {

website/docs/d/ad_access_credentials.html.md

@@ -8,6 +8,9 @@ description: |-
 
 # vault\_ad\_access\_credentials
 
+~> **Note** This data source is replaced by "vault_ldap_static_credentials" and
+will be removed in the next major release.
+
 Reads Active Directory credentials from an AD secret backend in Vault.
 
 ~> **Important** All data retrieved from Vault will be

website/docs/r/ad_secret_backend.html.md

@@ -8,6 +8,9 @@ description: |-
 
 # vault\_ad\_secret\_backend
 
+~> **Note** This resource is replaced by "vault_ldap_secret_backend" and will
+be removed in the next major release.
+
 Creates an Active Directory Secret Backend for Vault. Active Directory secret backend
 rotates existing Active Directory service account passwords based on the TTL of the role.
 

website/docs/r/ad_secret_backend_library.html.md

@@ -8,6 +8,9 @@ description: |-
 
 # vault\_ad\_secret\_backend\_library
 
+~> **Note** This resource is replaced by "vault_ldap_secret_backend_library_set"
+and will be removed in the next major release.
+
 Creates a library on an Active Directory Secret Backend for Vault. Libraries create
 a pool of existing Active Directory service accounts which can be checked out
 by users.

website/docs/r/ad_secret_role.html.md

@@ -8,6 +8,9 @@ description: |-
 
 # vault\_ad\_secret\_role
 
+~> **Note** This resource is replaced by "vault_ldap_secret_backend_static_role"
+and will be removed in the next major release.
+
 Creates a role on an Active Directory Secret Backend for Vault. Roles are
 used to map credentials to existing Active Directory service accounts.