Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate ad secret resources #1837

Closed
wants to merge 7 commits into from
Closed

deprecate ad secret resources #1837

wants to merge 7 commits into from

Conversation

fairclothjm
Copy link
Contributor

This PR marks the ad secret resources as deprecated.

The Active Directory (AD) secrets engine has been deprecated as of the Vault 1.13 release. See the deprecation table: https://developer.hashicorp.com/vault/docs/deprecation

With the upcoming LDAP secrets resources we can mark these resources as deprecated and follow our deprecation process which broadly involves:

  • Mark the resource/field as deprecated.
  • Update the docs for the related resources/fields
  • Provide guidance on how to migrate
  • Eventually remove the feature all together. Normally we do that with a major version upgrade.

vinay-gopalan and others added 3 commits April 17, 2023 12:50
@vinay-gopalan
Update CHANGELOG.md for 3.15.0 release (#1824)
4346ded
@benashz
Ensure that the auth_login honours the provider's namespace (#1830)
5d5882e 
Previously, when any auth_login was configured with provider.namespace,
the login would not be done in the correct namespace. This was a big
problem for HCP Vault users, since the default namespace for on an HCP
Vault cluster is admin.

* Only set the parent client's namespace once.
@fairclothjm
deprecate ad secrets resources
4544387
@fairclothjm fairclothjm requested a review from a team May 3, 2023 16:45
vinay-gopalan and others added 2 commits May 3, 2023 13:24
@vinay-gopalan
Update changelog for 3.15.1 release (#1839)
f0be592
@benashz
Revert #1830 (#1840)
88ca629 
* Revert "Ensure that the auth_login honours the provider's namespace (#1830)"

This reverts commit 5d5882e.

* Update changelog
@vinay-gopalan
Copy link
Contributor

Should the merge branch be VAULT-8099/secrets/ldap? Wondering if we want to merge this into main along with all the LDAP resources so they can all be released together 🤔

@fairclothjm
Copy link
Contributor Author

Should the merge branch be VAULT-8099/secrets/ldap

Yeah that makes sense. I was meaning to ask you when you thought we should merge this so thanks for the answer! You were reading my mind!

@fairclothjm fairclothjm changed the base branch from main to VAULT-8099/secrets/ldap May 5, 2023 15:15
@github-actions github-actions bot added size/M and removed size/S labels May 5, 2023
@fairclothjm fairclothjm mentioned this pull request May 5, 2023
Merged
@fairclothjm
Copy link
Contributor Author

The commits got weird when changing the base of this PR and merging main did not help so I am closing.

This PR is superseded by #1837

@fairclothjm fairclothjm closed this May 5, 2023
@fairclothjm fairclothjm deleted the VAULT-15213/deprecate-ad-resources branch October 11, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymonstah raymonstah raymonstah approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fairclothjm @vinay-gopalan @raymonstah @benashz @jsab