Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time_rotating argument name #2911

Conversation

modular-magician
Copy link
Collaborator

Upstreams: hashicorp/terraform-provider-google#8309

One of the example definitions shows rotate_days as argument of time_rotating resource.

This argument should be called rotation_days , as defined at the current resource documentation (as of today using version 0.6.0).

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#4435

One of the example definitions shows `rotate_days` as argument of `time_rotating` resource.

This argument should be called `rotation_days `, as defined at the current [resource documentation](https://registry.terraform.io/providers/hashicorp/time/latest/docs/resources/rotating#rotation_days) (as of today using version `0.6.0`).

Co-authored-by: Nicolas Singh Oteiza <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xs label Jan 27, 2021
@modular-magician modular-magician merged commit 045b6b0 into hashicorp:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant