Skip to content

Commit

Permalink
Fix time_rotating argument name (#4435) (#2911)
Browse files Browse the repository at this point in the history
One of the example definitions shows `rotate_days` as argument of `time_rotating` resource.

This argument should be called `rotation_days `, as defined at the current [resource documentation](https://registry.terraform.io/providers/hashicorp/time/latest/docs/resources/rotating#rotation_days) (as of today using version `0.6.0`).

Co-authored-by: Nicolas Singh Oteiza <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Nicolas Singh Oteiza <[email protected]>
  • Loading branch information
modular-magician and nicosingh authored Jan 27, 2021
1 parent a262e3e commit 045b6b0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .changelog/4435.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:none

```
2 changes: 1 addition & 1 deletion google-beta/resource_dataflow_flex_template_job_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
"google.golang.org/api/compute/v1"
compute "google.golang.org/api/compute/v1"
)

func TestAccDataflowFlexTemplateJob_basic(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/google_service_account_key.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ resource "google_service_account" "myaccount" {
# note this requires the terraform to be run regularly
resource "time_rotating" "mykey_rotation" {
rotate_days = 30
rotation_days = 30
}
resource "google_service_account_key" "mykey" {
Expand Down

0 comments on commit 045b6b0

Please sign in to comment.