Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forward_to property to servicebus subscription resource #861

Merged
merged 5 commits into from
Feb 23, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Feb 20, 2018

Adds forward_to property to servicebus subscription resource & fixes #810.

@katbyte katbyte changed the title F servicebus sub autoforward Add forward_to property to servicebus subscription resource Feb 20, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly LGTM - if we can split out the test this should be good to merge 👍

@@ -98,6 +98,9 @@ The following arguments are supported:
supports the concept of a session. Defaults to false. Changing this forces a
new resource to be created.

* `forward_to` - (Optional) The name of a Queue or Topic to automatically forward
messages to. Defaults to none.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the Defaults to none section here

"forward_to": {
Type: schema.TypeString,
Optional: true,
Description: "The name of a Queue or Topic to automatically forward messages to.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed on Slack, we don't generally specify the description for schema fields in the Azure Provider - we may in the future when there's a value for it (but there's no harm in leaving this in 😄)

}


`, rInt, location, rInt, rInt, rInt, rInt)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make a specific test for forward to, since it's an optional field? we tend to use _basic to signify only the required fields

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte
Copy link
Collaborator Author

katbyte commented Feb 23, 2018

Tests passed.

screen shot 2018-02-22 at 16 29 49

@katbyte katbyte merged commit 1381dde into master Feb 23, 2018
katbyte added a commit that referenced this pull request Feb 23, 2018
@katbyte katbyte deleted the f-servicebus-sub-autoforward branch February 28, 2018 20:04
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Service Bus Subscription AutoForward
2 participants