Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Service Bus Subscription AutoForward #810

Closed
tribet84 opened this issue Feb 8, 2018 · 10 comments · Fixed by #861
Closed

Feature Request: Service Bus Subscription AutoForward #810

tribet84 opened this issue Feb 8, 2018 · 10 comments · Fixed by #861

Comments

@tribet84
Copy link

tribet84 commented Feb 8, 2018

Subscription ForwardTo property is a very powerful feature in service bus but a particularly tricky thing to configure (e.g. the new Azure portal doesn't even provide a mechanism).

It would be awesome to be able to configure AutoForward from terraform. At the moment I'm using terraform azurerm_template_deployment resource to inject the following arm, hope helps:

{
   "$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",
   "contentVersion": "1.0.0.0",
   "parameters": {
     "namespaceName": {
       "type": "string"
     },
     "topicName": {
       "type": "string"
     },
     "subscriptionName": {
       "type": "string"
     },
     "autoForwardTo": {
       "type": "string"
     }
   },
   "variables": {
     "subscriptionPath": "[concat(parameters('namespaceName'), '/', parameters('topicName'), '/', parameters('subscriptionName'))]"
   },
   "resources": [
     {
       "apiVersion": "2015-08-01",
       "name":  "[variables('subscriptionPath')]",
       "type": "Microsoft.ServiceBus/namespaces/topics/subscriptions",
       "location": "[resourceGroup().location]",
       "properties": {
           "forwardTo": "[parameters('autoForwardTo')]"
       }
     }
   ],
   "outputs": {
   }
}
@tombuildsstuff
Copy link
Contributor

hey @tribet84

Thanks for opening this issue

Taking a quick look into this it appears support for ForwardTo is available in the Azure SDK for Go - as such we should be able to add support for this in the near future :)

Thanks!

@tombuildsstuff tombuildsstuff added this to the 1.1.3 milestone Feb 8, 2018
@tribet84
Copy link
Author

tribet84 commented Feb 8, 2018

Thanks for the quick answer @tombuildsstuff Any (rough) deadline? my company is assessing infrastructure tools and terraform looks interesting.

@tombuildsstuff
Copy link
Contributor

@tribet84 since it's not a big change and it already exists in the SDK - my guess would be that we'd get to this sometime in the next couple of weeks. Hope that helps

@tombuildsstuff tombuildsstuff modified the milestones: 1.1.3, 1.1.2 Feb 8, 2018
@tribet84
Copy link
Author

tribet84 commented Feb 8, 2018 via email

@jpovey
Copy link
Contributor

jpovey commented Feb 21, 2018

We are also about starting to start trailing using terraform with azure. One of our key components makes use of auto forwarding so this feature would be hugely beneficial for us

It looks like this change is almost ready to be approved?

@katbyte
Copy link
Collaborator

katbyte commented Feb 22, 2018

Hi @jpovey

That is correct, I expect this change to be approved and merged soon.

katbyte added a commit that referenced this issue Feb 23, 2018
…oforward

Add forward_to property to servicebus subscription resource. Fixes #810
@tribet84
Copy link
Author

I work for a company called ASOS and we are close to adopting Terraform in production. The fact that you guys got this request finished in 15 days may help me to convince my managers to move forward using this great tool. Do you guys know when the release will be public?

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Feb 23, 2018

@tribet84 glad to hear it solves your issue - we should be doing a release next week :)

@tombuildsstuff
Copy link
Contributor

👋 hey @tribet84

Just to let you know that support for this has just been released in v1.2.0 of the AzureRM Provider - full details of what's included are available here: https://github.com/terraform-providers/terraform-provider-azurerm/blob/v1.2.0/CHANGELOG.md#120-march-02-2018

Thanks!

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants