azurerm_kubernetes_cluster_node_pool - node_count, min_node, and max_node can now be set to 0

[zeroX-tj]

This updates the validation rules for the new Azure SDK where you can create zero size nodepools

#8219

If there's anything else i should do, let me know, first PR. I tested it locally by using it.

[mbfrahry]

Hey @zeroX-tj, this change looks good but can we add a test to confirm we can make a node pool with a node count of 0 and another test for a min count of 0

[gdippolito]

I think this would be really nice to have. @zeroX-tj are you looking into addressing the comment?

[zeroX-tj]

I think this would be really nice to have. @zeroX-tj are you looking into addressing the comment?

I'm really not so familiar with Go so i was planning in looking into it when i had more time. But that didn't happen yet.

[migolfi]

This looks great and it would be very helpful for some work I am currently on. Is there anything else needed on this?
It looks like it's waiting for feedback from @mbfrahry

[mbfrahry]

Hey @zeroX-tj. These changes look good and the test changes works! We are missing two things after further review. max_count validation should also start at 0 since it can be greater than or equal to min_count and we need to update the docs to reflect the changes here and we'll be good to go. https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/website/docs/r/kubernetes_cluster_node_pool.html.markdown

[zeroX-tj]

Sorry for the reverts, was a bit confused by the failed builds but then i figured out it's because of cancelation :) Monday mornings

I think everything should be good now.

[mbfrahry]

LGTM!

[mbfrahry]

Thanks for this @zeroX-tj!

[ghost]

This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.31.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!