-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/kubernetes_cluster: handling breaking changes in the AKS API #6095
Commits on Apr 1, 2020
-
Potential fix for hashicorp#6020
If autoscaling is disabled on default_node_pool, those values are set to `0`
Configuration menu - View commit details
-
Copy full SHA for 50fda65 - Browse repository at this point
Copy the full SHA 50fda65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5498920 - Browse repository at this point
Copy the full SHA 5498920View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9be600d - Browse repository at this point
Copy the full SHA 9be600dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e8b682 - Browse repository at this point
Copy the full SHA 6e8b682View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec70994 - Browse repository at this point
Copy the full SHA ec70994View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79c93b7 - Browse repository at this point
Copy the full SHA 79c93b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 385d8a7 - Browse repository at this point
Copy the full SHA 385d8a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 860dae6 - Browse repository at this point
Copy the full SHA 860dae6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d064ab2 - Browse repository at this point
Copy the full SHA d064ab2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 358b454 - Browse repository at this point
Copy the full SHA 358b454View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b31417 - Browse repository at this point
Copy the full SHA 3b31417View commit details -
r/kubernetes_cluster: conditionally specifying either the service_pri…
…ncipal or MSI blocks Previously it was possible to use a Service Principal for an AKS Cluster and also give it a Managed Identity. However due to a breaking change in the AKS API this is no longer possible. Instead attempting to do this via the API creates an MSI Enabled cluster and ignores the Service Principal that's specified - as such it's only possible to create a Service Principal or MSI cluster, not the Service Principal cluster with a Managed Identity attached as before.
Configuration menu - View commit details
-
Copy full SHA for edb4e3a - Browse repository at this point
Copy the full SHA edb4e3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42d37f2 - Browse repository at this point
Copy the full SHA 42d37f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56de89e - Browse repository at this point
Copy the full SHA 56de89eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a17ea9 - Browse repository at this point
Copy the full SHA 5a17ea9View commit details -
r/kubernetes_cluster: moving the rest of the functions into parse/val…
…idate since these now exist
Configuration menu - View commit details
-
Copy full SHA for 57b6e9a - Browse repository at this point
Copy the full SHA 57b6e9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 673f47b - Browse repository at this point
Copy the full SHA 673f47bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c1a4ef - Browse repository at this point
Copy the full SHA 4c1a4efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23b8cbb - Browse repository at this point
Copy the full SHA 23b8cbbView commit details -
r/kubernetes_cluster(_node_pool): requiring that
min_count
and `max……_count` are set to `null` not 0 when undefined This updates the error message to match the behaviour of the existing resources, where the `_count` fields can be set to `null` rather than `0` in a coalesce function - for example: ``` locals { enable_auto_scale = false fixed_count = 2 min_count = 1 max_count = 4 } resource "azurerm_kubernetes_cluster" "test" { # ... default_node_pool { enable_auto_scaling = local.enable_auto_scale node_count = local.enable_auto_scale ? null : local.fixed_count min_count = local.enable_auto_scale ? local.min_count : null max_count = local.enable_auto_scale ? local.max_count : null } } ```
Configuration menu - View commit details
-
Copy full SHA for 6819422 - Browse repository at this point
Copy the full SHA 6819422View commit details
Commits on Apr 2, 2020
-
r/kubernetes_cluster: messaging the behavioural differences in the AK…
…S API Due to a breaking change in the AKS API - it's no longer possible to create mixed-mode clusters (e.g. using both a Service Principal and a Managed Identity). This commit attempts to correctly message this behaviour, whilst trying to ensure we can adequately capture this behaviour within Terraform
Configuration menu - View commit details
-
Copy full SHA for 1837de7 - Browse repository at this point
Copy the full SHA 1837de7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3a1905 - Browse repository at this point
Copy the full SHA f3a1905View commit details
Commits on Apr 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fa97d31 - Browse repository at this point
Copy the full SHA fa97d31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3de8ac9 - Browse repository at this point
Copy the full SHA 3de8ac9View commit details -
r/kubernetes_cluster(_node_pool): ensuring that tags are set on the d…
…efault node pool Also fixing a bug where min/max count would be unmodified during updates
Configuration menu - View commit details
-
Copy full SHA for c5e87d8 - Browse repository at this point
Copy the full SHA c5e87d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6472a45 - Browse repository at this point
Copy the full SHA 6472a45View commit details
Commits on Apr 6, 2020
-
r/kubernetes_cluster_node_pool: explicitly requiring
null
rather th……an `0` When coalescing between these values - this should be set to `null` rather than `0` - and fixes the error message which caused the initial confusion. Whilst setting this field to `0` is convenient - it breaks validation for when auto-scaling is enabled - as such `0` shouldn't be an allowed value for `min_count` or `max_count` (since node pools can't be scaled to `0` in the API) Instead users can coaslesce this via: ``` locals { enable_auto_scale = false fixed_count = 2 min_count = 1 max_count = 4 } resource "azurerm_kubernetes_cluster_node_pool" "test" { # ... enable_auto_scaling = local.enable_auto_scale node_count = local.enable_auto_scale ? null : local.fixed_count min_count = local.enable_auto_scale ? local.min_count : null max_count = local.enable_auto_scale ? local.max_count : null } ```
Configuration menu - View commit details
-
Copy full SHA for 977b202 - Browse repository at this point
Copy the full SHA 977b202View commit details -
r/kubernetes_cluster: fixing the docs for the
vnet_subnet_id
fieldOriginally made by @adback03 in hashicorp#6357
Configuration menu - View commit details
-
Copy full SHA for 824e57f - Browse repository at this point
Copy the full SHA 824e57fView commit details -
r/kubernetes_cluster(_node_pool): updating the docs to handle `min_co…
…unt`/`max_count` being null
Configuration menu - View commit details
-
Copy full SHA for 3b8c9de - Browse repository at this point
Copy the full SHA 3b8c9deView commit details -
r/kubernetes_cluster: moving the
service_principal
block with the o……ther optional props
Configuration menu - View commit details
-
Copy full SHA for 667d71c - Browse repository at this point
Copy the full SHA 667d71cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4abba5e - Browse repository at this point
Copy the full SHA 4abba5eView commit details