Cannot set max_count and min_count to zero when autoscaling is false

[SvenHamers]

when creating a some locic in the node pool it is not possible to set the value to 0

Example:
min_count = var.default_autoscaling_enabled ? var.default_min_node_count : 0
max_count = var.default_autoscaling_enabled ? var.default_min_node_count: 0

The output of the following says it should be possible

else if minCount > 0 || maxCount > 0 {
return fmt.Errorf("max_count and min_count must be set to 0 when enable_auto_scaling is set to false")

[katbyte]

Thanks for the PR @SvenHamers, instead of removing the validation can we just expand it to include 0? thanks!

[katbyte]

Thanks @SvenHamers! LGTM 👍

[ghost]

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

[wagnst]

Hi @katbyte @SvenHamers,

I think this might have broken something in the default_node_pool if this code is also used there (I am not sure). When I update an existing AKS cluster with the new provider 2.1.0 I get:

Error: Error updating Default Node Pool "lhg-weur-kfkadevmdw-aks" (Resource Group "lhg-weur-kfkadevmdwaks-rg"): containerservice.AgentPoolsClient#CreateOrUpdate: Invalid input: autorest/validation: validation failed: parameter=parameters.ManagedClusterAgentPoolProfileProperties.Count constraint=Null value=(*int32)(nil) details: value can not be null; required parameter

The code bascially is

...
default_node_pool {
    ...
    node_count          = 1
    enable_auto_scaling = false
    ...
}
...

I explicitly do NOT set min_count and max_count at all in that case (autoscaling = false). But when I check the state this is set (again), although if I remove the fields manually from it - maybe thats not relevant and is the default behavior anyways:

    default_node_pool {
        availability_zones    = [
            "1",
        ]
        enable_auto_scaling   = false
        enable_node_public_ip = false
        max_count             = 0
        max_pods              = 250
        min_count             = 0
        name                  = "default"
        node_count            = 1
        node_labels           = {}
        node_taints           = []
        os_disk_size_gb       = 128
        tags                  = {}
        type                  = "VirtualMachineScaleSets"
        vm_size               = "Standard_D2s_v3"
        vnet_subnet_id        = "/subscriptions/xxx/resourceGroups/yyy/providers/Microsoft.Network/virtualNetworks/zzz/subnets/aaa"
    }

Is this related to this one or is this a new issue? Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!