-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the azurerm_cost_management_export_resource_group has been deprecated in favour of azurerm_resource_group_cost_management_export, azurerm_subscription_cost_management_export #14140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stephybun - left some comments inline whilst passing through
"recurrence_period_start": { | ||
Type: pluginsdk.TypeString, | ||
Required: true, | ||
ValidateFunc: validation.IsRFC3339Time, | ||
}, | ||
|
||
"recurrence_period_end": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be explicit this is a time value?
"recurrence_period_start": { | |
Type: pluginsdk.TypeString, | |
Required: true, | |
ValidateFunc: validation.IsRFC3339Time, | |
}, | |
"recurrence_period_end": { | |
"recurrence_period_start_time": { | |
Type: pluginsdk.TypeString, | |
Required: true, | |
ValidateFunc: validation.IsRFC3339Time, | |
}, | |
"recurrence_period_end_time": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point, I think it would make more sense to go with recurrence_period_start_date
in this case.
website/docs/r/resource_group_cost_management_export.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/subscription_cost_management_export.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/subscription_cost_management_export.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/subscription_cost_management_export.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @stephybun
Thanks for this PR.
I've taken a look through and left a few comments inline, but this otherwise LGTM 👍
Thanks!
website/docs/r/subscription_cost_management_export.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/subscription_cost_management_export.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/subscription_cost_management_export.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/resource_group_cost_management_export.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/resource_group_cost_management_export.html.markdown
Outdated
Show resolved
Hide resolved
Thanks for the review @katbyte and @tombuildsstuff. Have hopefully addressed all of your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stephybun - LGTM 🚀
This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Partially closes #11598