Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the azurerm_cost_management_export_resource_group has been deprecated in favour of azurerm_resource_group_cost_management_export, azurerm_subscription_cost_management_export #14140

Merged
merged 17 commits into from
Nov 19, 2021

Conversation

stephybun
Copy link
Member

Partially closes #11598

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - left some comments inline whilst passing through

Comment on lines 41 to 47
"recurrence_period_start": {
Type: pluginsdk.TypeString,
Required: true,
ValidateFunc: validation.IsRFC3339Time,
},

"recurrence_period_end": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be explicit this is a time value?

Suggested change
"recurrence_period_start": {
Type: pluginsdk.TypeString,
Required: true,
ValidateFunc: validation.IsRFC3339Time,
},
"recurrence_period_end": {
"recurrence_period_start_time": {
Type: pluginsdk.TypeString,
Required: true,
ValidateFunc: validation.IsRFC3339Time,
},
"recurrence_period_end_time": {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point, I think it would make more sense to go with recurrence_period_start_date in this case.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @stephybun

Thanks for this PR.

I've taken a look through and left a few comments inline, but this otherwise LGTM 👍

Thanks!

internal/services/costmanagement/export_base_resource.go Outdated Show resolved Hide resolved
internal/services/costmanagement/export_base_resource.go Outdated Show resolved Hide resolved
internal/services/costmanagement/export_base_resource.go Outdated Show resolved Hide resolved
internal/services/costmanagement/export_base_resource.go Outdated Show resolved Hide resolved
internal/services/costmanagement/export_base_resource.go Outdated Show resolved Hide resolved
@stephybun
Copy link
Member Author

Thanks for the review @katbyte and @tombuildsstuff. Have hopefully addressed all of your comments.

@katbyte katbyte added this to the v2.86.0 milestone Nov 19, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM 🚀

@katbyte katbyte changed the title Cost management base resource with resource group and subscription scope ththe azurerm_cost_management_export_resource_group has been deprecated in favour of azurerm_resource_group_cost_management_export, azurerm_subscription_cost_management_export Nov 19, 2021
@katbyte katbyte merged commit f1e4668 into main Nov 19, 2021
@katbyte katbyte deleted the f/cost-mgmt-export-base branch November 19, 2021 01:51
@katbyte katbyte changed the title ththe azurerm_cost_management_export_resource_group has been deprecated in favour of azurerm_resource_group_cost_management_export, azurerm_subscription_cost_management_export the azurerm_cost_management_export_resource_group has been deprecated in favour of azurerm_resource_group_cost_management_export, azurerm_subscription_cost_management_export Nov 19, 2021
katbyte added a commit that referenced this pull request Nov 19, 2021
@github-actions
Copy link

This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement cost management export for all scopes, not just resource group
3 participants