Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow permanent delete of log_analytics_workspace_resource #10235

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

lde
Copy link
Contributor

@lde lde commented Jan 18, 2021

Allow permanent delete of log_analytics_workspace_resource without go to recycle bin.

@lde
Copy link
Contributor Author

lde commented Jan 18, 2021

refers issue #7282

@lde lde force-pushed the delete_log_analytics branch 2 times, most recently from eb0cc65 to 4877781 Compare January 18, 2021 19:08
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lde - thanks for this pr, however due to the way terraform works we can't just put it into the schema. We'll have to add it to the providers feature block like purge_soft_delete_on_destroy or delete_os_disk_on_delete.

@lde
Copy link
Contributor Author

lde commented Feb 12, 2021

Pr updated for use feature block.

@ghost ghost removed the waiting-response label Feb 12, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lde, Aside from one comment about the property name this is looking good

azurerm/internal/provider/features.go Outdated Show resolved Hide resolved
@lde
Copy link
Contributor Author

lde commented Feb 18, 2021

changes applied.

@rick-ha
Copy link

rick-ha commented Mar 4, 2021

hello - what is the status on this? I read that Ide made his changes - is there another underlying issue?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lde - LGTM now 👍

@katbyte katbyte added this to the v2.50.0 milestone Mar 5, 2021
@katbyte katbyte merged commit af6a75c into hashicorp:master Mar 5, 2021
katbyte added a commit that referenced this pull request Mar 5, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants