-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow permanent delete of log_analytics_workspace_resource #10235
Conversation
5e08ad6
to
41dd191
Compare
refers issue #7282 |
eb0cc65
to
4877781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lde - thanks for this pr, however due to the way terraform works we can't just put it into the schema. We'll have to add it to the providers feature block like purge_soft_delete_on_destroy
or delete_os_disk_on_delete
.
4877781
to
0bf597e
Compare
Pr updated for use feature block. |
0bf597e
to
48cac53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lde, Aside from one comment about the property name this is looking good
Co-authored-by: kt <[email protected]>
changes applied. |
db40bf2
to
3cb03fd
Compare
3cb03fd
to
f1c1752
Compare
hello - what is the status on this? I read that Ide made his changes - is there another underlying issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lde - LGTM now 👍
This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.50.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Allow permanent delete of log_analytics_workspace_resource without go to recycle bin.