Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managed_application only supports string as parameters #8608

Closed
Dilergore opened this issue Sep 24, 2020 · 4 comments · Fixed by #8632
Closed

managed_application only supports string as parameters #8608

Dilergore opened this issue Sep 24, 2020 · 4 comments · Fixed by #8632

Comments

@Dilergore
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Affected Resource(s)

  • azurerm_managed_application

Terraform Configuration Files

resource "azurerm_managed_application" "CBS" {
  name                        = "CBD"
  location                    = azurerm_resource_group.example.location
  resource_group_name         = azurerm_resource_group.example.name
  kind                        = "MarketPlace"
  managed_resource_group_name = "managed-rg-name"

  parameters = {
    location                  = "eastus"
    zone                      = 1
    arrayName                 = "purearrayname"
    orgDomain                 = "domain.com"
    licenseKey                = "XXXXXXX-XXXXXXX-XXXXXXX-XXXXXXX-XXXXXXX"
    vnetName                  = "vnetname"
    vnetResourceGroupName     = "vnetrgname"
    systemInterfaceSubnetName = "CBS_system"
    subnetName                = "CBS_management"
    #additionalTags           = ""
    alertRecipients           = "[email protected]"
    #pureuserPublicKey        = ""
    setupHA                   = false
    setupInitiator            = false
    sku                       = "small"
    useProximityGroup         = false
  }

  plan  {
    name        = "6_0_0_beta4-0f043f4"
    product     = "cloud_block_store_beta-preview"
    publisher   = "purestorageinc1578960262525"
    version     = "1.0.0"
  }
}

Error message

Error: failed to wait for creation of Managed Application "CBD" (Resource Group "CBS-Resourcegroup"): Code="ApplianceProvisioningFailed" Message="Deployment template validation failed: 'Template parameter JToken type is not valid. Expected 'Boolean'. Actual 'String'. Please see https://aka.ms/resource-manager-parameter-files for usage details.'." AdditionalInfo=[{"info":{"lineNumber":48,"linePosition":20,"path":"parameters.setupHA"},"type":"TemplateViolation"}]

Expected Behavior

Be able to specify parameters properly with type. Today all the params are getting converted to a string. While it works for what we have in the documented examples, there are managed applications waiting for non-string vals.

Actual Behavior

All the values are getting converted to a string causing deployment issues for apps waiting for other kind of parameter types.

Steps to Reproduce

We tried to deploy Pure CBS closed beta as a Managed App. I strongly believe there can be other managed apps waiting for non-string parameters.

@neil-yechenwei
Copy link
Contributor

Thanks for opening this issue. Hopes the fix would be helpful.

@Dilergore
Copy link
Contributor Author

Thanks for opening this issue. Hopes the fix would be helpful.

TYVM, hope it will be part of the next release.

@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants