Support non-string type for parameters of azurerm_managed_application

[neil-yechenwei]

fixes #8608

[Dilergore]

Bump! Please merge this asap we really need this.

[katbyte]

Thanks for the pr @neil-yechenwei - looking at this i'm wondering if it would be better to instead support both and make them conflict? either parameters for those who need a simple key=value and then paramters_as_json for users who want to just pass in a json block?

[neil-yechenwei]

@katbyte , thanks for your comments. I've updated code. Please have an another look. Thanks.

[katbyte]

Thanks @neil-yechenwei - couple more comments to address and this should be good to merge

[katbyte]

could we add a test that goes string -> non-string -> string and checking to make sure the correct property is used?

[neil-yechenwei]

Added tc

[neil-yechenwei]

@katbyte , thanks for your comments. I've updated code. Please have an another look. Thanks.

[katbyte]

thanks @neil-yechenwei, looks good. There are two test failures:

------- Stdout: -------
=== RUN   TestAccManagedApplication_complete
=== PAUSE TestAccManagedApplication_complete
=== CONT  TestAccManagedApplication_complete
    testing.go:620: Step 1/2 error: Error running apply: exit status 1
        
        Error: A resource with the ID "/subscriptions/*******/providers/Microsoft.MarketplaceOrdering/agreements/cisco/offers/meraki-vmx/plans/meraki-vmx100" already exists - to be managed via Terraform this resource needs to be imported into the State. Please see the resource documentation for "azurerm_marketplace_agreement" for more information.
        
          on terraform_plugin_test.tf line 35, in resource "azurerm_marketplace_agreement" "test":
          35: resource "azurerm_marketplace_agreement" "test" {
        
--- FAIL: TestAccManagedApplication_complete (106.85s)
FAIL

------- Stderr: -------
2021/04/27 04:03:28 [DEBUG] not using binary driver name, it's no longer needed
2021/04/27 04:03:28 [DEBUG] not using binary driver name, it's no longer needed
 ------- Stdout: -------
=== RUN   TestAccManagedApplication_update
=== PAUSE TestAccManagedApplication_update
=== CONT  TestAccManagedApplication_update
    testing.go:620: Step 3/6 error: Error running apply: exit status 1
        
        Error: A resource with the ID "/subscriptions/*******/providers/Microsoft.MarketplaceOrdering/agreements/cisco/offers/meraki-vmx/plans/meraki-vmx100" already exists - to be managed via Terraform this resource needs to be imported into the State. Please see the resource documentation for "azurerm_marketplace_agreement" for more information.
        
          on terraform_plugin_test.tf line 35, in resource "azurerm_marketplace_agreement" "test":
          35: resource "azurerm_marketplace_agreement" "test" {
        
--- FAIL: TestAccManagedApplication_update (437.25s)
FAIL

------- Stderr: -------
2021/04/27 04:03:28 [DEBUG] not using binary driver name, it's no longer needed
2021/04/27 04:03:28 [DEBUG] not using binary driver name, it's no longer needed

once fixed this should be good to merge!

[neil-yechenwei]

@katbyte , I assume it's your test env issue. Please cancel the related term first in your test env with command before run test case.

[katbyte]

Looks like it's an ongoing problem on master to, these tests always fail in TC - should look into a way to fix them so they don't fail anymore but it doesn't block this pr 👍

[ghost]

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.