Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Outbound Rules in Standard Load Balancer #1984

Closed
PleaseStopAsking opened this issue Sep 26, 2018 · 13 comments
Closed

Add support for Outbound Rules in Standard Load Balancer #1984

PleaseStopAsking opened this issue Sep 26, 2018 · 13 comments

Comments

@PleaseStopAsking
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Azure has just announced support for Outbound Rules on Standard Sku Load Balancers. Outbound rules make it simple to configure public Standard Load Balancer's outbound network address translation. You have full declarative control over outbound connectivity to scale and tune this ability to your specific needs.

New or Affected Resource(s)

azurerm_lb_outbound_rule

Potential Terraform Configuration

resource "azurerm_public_ip" "test" {
  name                         = "PublicIPForLB"
  location                     = "West US"
  resource_group_name          = "${azurerm_resource_group.test.name}"
  public_ip_address_allocation = "static"
}

resource "azurerm_lb" "test" {
  name                = "TestLoadBalancer"
  location            = "West US"
  resource_group_name = "${azurerm_resource_group.test.name}"

  frontend_ip_configuration {
    name                 = "PublicIPAddress"
    public_ip_address_id = "${azurerm_public_ip.test.id}"
  }
}

resource "azurerm_lb_backend_address_pool" "test" {
  resource_group_name = "${azurerm_resource_group.test.name}"
  loadbalancer_id     = "${azurerm_lb.test.id}"
  name                = "BackEndAddressPool"
}

resource "azurerm_lb_outbound_rule" "test" {
  resource_group_name = "${azurerm_resource_group.test.name}"
  loadbalancer_id = "${azurerm_lb.test.id}"
  name = "outboundRule"
  frontend_ip_configurations = "PublicIPAddress"
  idleTimeoutInMinutes = 60
  enableTcpReset = $true 
  protocol = "All"
  backendAddressPool = ["${azurerm_lb_backend_address_pool.test.id}"]
}

References

https://docs.microsoft.com/en-us/azure/load-balancer/load-balancer-outbound-rules-overview
https://docs.microsoft.com/en-us/azure/load-balancer/load-balancer-outbound-connections#ilpip

@PleaseStopAsking
Copy link
Author

@metacpp As I am not as familiar with the GO SDK, how can we confirm that support for Outbound Rules exists?

@metacpp metacpp removed their assignment Nov 4, 2018
@metacpp
Copy link
Contributor

metacpp commented Nov 4, 2018

@metacpp metacpp changed the title Add support for Outbound Rules in Standard Load Balancer [Feature Request]Add support for Outbound Rules in Standard Load Balancer Nov 4, 2018
@PleaseStopAsking
Copy link
Author

@metacpp As Outbound Rules are supported in the SDK starting at 2018-08-01, would this require updating the SDK in /vendor to the new version for all network resources or is there a way to only use it for load balancer resources?

I tested simply adding the new version to the network dir but as expected there are other dependencies with the new version.

@tombuildsstuff tombuildsstuff changed the title [Feature Request]Add support for Outbound Rules in Standard Load Balancer Add support for Outbound Rules in Standard Load Balancer Nov 5, 2018
@metacpp
Copy link
Contributor

metacpp commented Nov 6, 2018

@metacpp As Outbound Rules are supported in the SDK starting at 2018-08-01, would this require updating the SDK in /vendor to the new version for all network resources or is there a way to only use it for load balancer resources?

We're using v21.3.0 for Azure Go SDK, which contains the 2018-08-01:
https://github.com/Azure/azure-sdk-for-go/tree/v21.3.0/services/network/mgmt

You can just use below command to fetch package for 2018-08-01:

govendor fetch "github.com/Azure/azure-sdk-for-go/services/network/mgmt/2018-08-01/network"@v21.3.0

@mcharriere
Copy link
Contributor

Hi,
I could start working on this new resource now that it's using v24 for the SDK.
Is there anything that I should check before adding this feature?

@metacpp
Copy link
Contributor

metacpp commented Jan 31, 2019

@mcharriere Thanks for pointing it out.

Yes, you should use v24 now, and please also use the latest API version, 2018-10-01.

@djsly
Copy link
Contributor

djsly commented Feb 15, 2019

@mcharriere are you picking this up in the end?

@mcharriere
Copy link
Contributor

@mcharriere are you picking this up in the end?

Yes, I'm about to finish it. just polishing it a bit. I hope I'll have it done by Mondey

@djsly
Copy link
Contributor

djsly commented Feb 16, 2019 via email

@mcharriere
Copy link
Contributor

Hi. I think that this could be closed after merging the pull request. Did I miss something? Thanks

@tombuildsstuff tombuildsstuff added this to the 1.23.0 milestone Mar 1, 2019
@tombuildsstuff
Copy link
Contributor

@mcharriere thanks for the ping - agreed this can now be closed since #2912 has shipped - thanks 👍

katbyte pushed a commit that referenced this issue Mar 5, 2019
Adds missing links to new docs:

- data source: azurerm_recovery_services_protection_policy_vm #2311 
- resource: azurerm_lb_outbound_rule #1984
@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants