Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACM certificate: Additional attributes #26784

Merged
merged 26 commits into from
Sep 29, 2022
Merged

ACM certificate: Additional attributes #26784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
84ac8b9
r/aws_acm_certificate: Switch to 'WithoutTimeout' CRUD handler signat…
ewbankkit Sep 12, 2022
d8140c9
r/aws_acm_certificate_validation: Switch to 'WithoutTimeout' CRUD han…
ewbankkit Sep 12, 2022
3fd53c0
r/aws_acm_certificate(_validation): Pass context.
ewbankkit Sep 12, 2022
aa92ea2
d/aws_acm_certificate: Alphabetize attributes.
ewbankkit Sep 12, 2022
73c15cf
d/aws_acm_certificate: Switch to 'WithoutTimeout' CRUD handler signat…
ewbankkit Sep 12, 2022
d39409e
Fix 'github.com/hashicorp/terraform-plugin-sdk/v2/diag.Errorf does no…
ewbankkit Sep 12, 2022
3f407e9
d/aws_acm_certificate: Tweaked error message.
ewbankkit Sep 12, 2022
c39bfec
% ACM_CERTIFICATE_ROOT_DOMAIN=ewbankkit.com make testacc TESTARGS='-r…
ewbankkit Sep 12, 2022
6c56cc7
r/aws_acm_certificate: Add 'type' attribute.
ewbankkit Sep 13, 2022
a0a0f60
Correct CHANGELOG entry file name.
ewbankkit Sep 13, 2022
c2a9cfe
r/aws_acm_certificate: Add 'renewal_eligibility' attribute.
ewbankkit Sep 13, 2022
082143a
r/aws_acm_certificate: Add 'renewal_summary' attribute.
ewbankkit Sep 13, 2022
adc2619
Cleanup
gdavison Sep 21, 2022
ca30852
Updates `TestAccACMCertificate_privateCert` to successfully issue cer…
gdavison Sep 21, 2022
eb0c5c7
Uses `ComposeAggregateTestCheckFunc`
gdavison Sep 21, 2022
7876ec8
Adds check for status after certificate renewal
gdavison Sep 23, 2022
fc990ad
Adds tests for private certificates with and without permissions to r…
gdavison Sep 24, 2022
aa7be42
Adds `renewal_status_reason` for unsuccessful renewal
gdavison Sep 24, 2022
2286819
Cleanup
gdavison Sep 26, 2022
ceffee1
Clarifies documentation
gdavison Sep 26, 2022
9e1cd1f
Reorder tests
gdavison Sep 26, 2022
3641e15
Adds `early_renewal_duration`
gdavison Sep 27, 2022
f7481f1
Add 'early_renewal_duration' and 'pending_renewal' to CHANGELOG entry.
ewbankkit Sep 27, 2022
94e255a
Handles renewals when modifying `early_renewal_duration`
gdavison Sep 28, 2022
78eec11
Updates `docscheck` make rule to be consistent with GitHub workflow. …
gdavison Sep 28, 2022
e9c97ec
Updates URLs for ACM PCA reference documentation
gdavison Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/26784.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_acm_certificate: Add `early_renewal_duration`, `pending_renewal`, `renewal_eligibility`, `renewal_summary` and `type` attributes
```
5 changes: 4 additions & 1 deletion GNUmakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,10 @@ docs-lint-fix:
docscheck:
@tfproviderdocs check \
-allowed-resource-subcategories-file website/allowed-subcategories.txt \
-ignore-side-navigation-data-sources aws_alb,aws_alb_listener,aws_alb_target_group,aws_kms_secret \
-enable-contents-check \
-ignore-file-missing-data-sources aws_alb,aws_alb_listener,aws_alb_target_group \
-ignore-file-missing-resources aws_alb,aws_alb_listener,aws_alb_listener_certificate,aws_alb_listener_rule,aws_alb_target_group,aws_alb_target_group_attachment \
-provider-name=aws \
-require-resource-subcategory
@misspell -error -source text CHANGELOG.md .changelog

Expand Down
Loading